Skip to content

Conversation

emlun
Copy link
Member

@emlun emlun commented Aug 21, 2024

Transplanted from emlun#8 (meta-PR into #9175) by request of @acolomb (see: emlun#8 (comment)).

This padding decrease currently applies to all collapsible panels, but this padding decrease may not be appropriate for all collapsible panels. In particular, it will not be appropriate for the collapsible panels introduced in emlun#8.

This padding decrease currently applies to _all_ collapsible panels, but this
padding decrease is not appropriate for all collapsible panels.
@emlun emlun requested a review from acolomb August 21, 2024 09:31
@calmh calmh changed the title Replace global "Panel padding decrease" style with targeted class gui: Replace global "Panel padding decrease" style with targeted class Aug 21, 2024
@acolomb
Copy link
Member

acolomb commented Aug 21, 2024

Note that this is a complete no-op change regarding GUI layout. Only the CSS classes are refactored, no visible changes.

@emlun emlun merged commit 7df75e6 into syncthing:main Aug 21, 2024
21 checks passed
@emlun emlun deleted the less-padding-class branch August 21, 2024 13:02
calmh added a commit that referenced this pull request Aug 21, 2024
* main:
  gui: Replace global "Panel padding decrease" style with targeted class (#9659)
calmh added a commit to calmh/syncthing that referenced this pull request Aug 25, 2024
* main:
  lib/protocol: Further interface refactor (syncthing#9396)
  gui: Replace global "Panel padding decrease" style with targeted class (syncthing#9659)
@calmh calmh added this to the v1.27.13 milestone Sep 11, 2024
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Aug 21, 2025
@syncthing syncthing locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants