Don't add empty device to config on init #8933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We usually want to ensure that our own device is present. However if the given device ID is the empty ID, we shouldn't do that. This is a legimate (though way too non-obvious) use-case when opening the config without knowing/caring about the device ID.
calmh
reviewed
Jun 10, 2023
calmh
approved these changes
Jun 10, 2023
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jun 14, 2023
* main: gui, man, authors: Update docs, translations, and contributors Don't add empty device to config on init (syncthing#8933) build: Push release files to cloud storage build: Generate .asc files for release packages (fixes syncthing#8897) build: Properly build all Debian archs (fixes syncthing#8898) gui: Avoid code generating HTML (syncthing#8923) gui: Remove HTML support in tooltips gui: Avoid code generating HTML (syncthing#8923) build: Tests should run with Go 1.20 on Windows (syncthing#8924) gui, man, authors: Update docs, translations, and contributors lib/model: Improve test for unignored parent directories (syncthing#8926) build: Update dependencies (syncthing#8925) gui: Remove HTML support in tooltips
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Jun 14, 2023
* main: build: Update some dependencies build: Make sure we get the latest matching Go version build: Multi arch Docker images with GitHub actions (ref syncthing#8834) lib/config, gui: Disallow some options in combination with "untrusted" (fixes syncthing#8920) (syncthing#8921) gui, man, authors: Update docs, translations, and contributors Don't add empty device to config on init (syncthing#8933) build: Push release files to cloud storage build: Generate .asc files for release packages (fixes syncthing#8897) build: Properly build all Debian archs (fixes syncthing#8898) gui: Avoid code generating HTML (syncthing#8923) gui: Remove HTML support in tooltips gui: Avoid code generating HTML (syncthing#8923) build: Tests should run with Go 1.20 on Windows (syncthing#8924) gui, man, authors: Update docs, translations, and contributors lib/model: Improve test for unignored parent directories (syncthing#8926) build: Update dependencies (syncthing#8925) gui: Remove HTML support in tooltips cmd/syncthing: Use correct binary when restarting monitor (syncthing#8919)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We usually want to ensure that our own device is present. However if the given device ID is the empty ID, we shouldn't do that. This is a legimate (though way too non-obvious) use-case when opening the config without knowing/caring about the device ID.