Skip to content

lib/model: Improve path generation for auto accepted folders (fixes #8859) #8860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

lib/model: Improve path generation for auto accepted folders (fixes #8859) #8860

merged 1 commit into from
Apr 11, 2023

Conversation

calmh
Copy link
Member

@calmh calmh commented Apr 9, 2023

  • Make sure we don't try to use empty last path components
  • Create the directory to "reserve" it once we've decided to use it

@calmh
lib/model: Improve path generation for auto accepted folders (fixes s…
edbc6c9 
…yncthing#8859)

- Make sure we don't try to use empty last path components
- Create the directory to "reserve" it once we've decided to use it
@calmh calmh requested a review from er-pa April 11, 2023 06:45
er-pa
er-pa approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@er-pa er-pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@calmh calmh merged commit f59ffc8 into syncthing:main Apr 11, 2023
calmh added a commit to calmh/syncthing that referenced this pull request Apr 13, 2023
@calmh
Merge branch 'main' into multiquic
d89a1bd 
* main:
  build: Update dependencies (syncthing#8869)
  lib/model: Improve path generation for auto accepted folders (fixes syncthing#8859) (syncthing#8860)
  docs: fix typo (syncthing#8857)
  gui, man, authors: Update docs, translations, and contributors
  lib/syncthing: Handle successful global migration (fixes syncthing#8851) (syncthing#8852)
calmh added a commit to calmh/syncthing that referenced this pull request Apr 14, 2023
@calmh
Merge branch 'main' into windowsfixtests
b69598f 
* main: (28 commits)
  build: Update dependencies (syncthing#8869)
  lib/model: Improve path generation for auto accepted folders (fixes syncthing#8859) (syncthing#8860)
  docs: fix typo (syncthing#8857)
  gui, man, authors: Update docs, translations, and contributors
  lib/syncthing: Handle successful global migration (fixes syncthing#8851) (syncthing#8852)
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Set enc. trailer size on pull (ref syncthing#8563, syncthing#8556) (syncthing#8839)
  lib/model: Fix file size inconsistency due to enc. trailer (syncthing#8840)
  gui, man, authors: Update docs, translations, and contributors
  cmd/stdiscorv: Fix database test (fixes syncthing#8828)
  lib/ur: Fix custom releases URL comparison
  gui: Remove untranslated strings from JSON files (syncthing#8836)
  all: Fix typos found by codespell (syncthing#8833)
  gui: Hide download progress legend when download progress is disabled
  gui, man, authors: Update docs, translations, and contributors
  lib/protocol: Handle encrypted requests without encrypted hash (fixes syncthing#8277) (syncthing#8827)
  build(deps): bump github.com/hashicorp/golang-lru/v2 from 2.0.1 to 2.0.2 (syncthing#8826)
  lib/config: Allow sub-second watcher delay (fixes syncthing#7859) (syncthing#7864)
  gui, man, authors: Update docs, translations, and contributors
  lib/protocol: Cache expensive key operations (fixes syncthing#8599) (syncthing#8820)
  ...
@calmh calmh added this to the v1.23.5 milestone Apr 28, 2023
calmh added a commit to calmh/syncthing that referenced this pull request May 9, 2023
@calmh
Merge branch 'main' into newglobbing
8c282de 
* main: (42 commits)
  all: Correct various typos (syncthing#8870)
  gui, man, authors: Update docs, translations, and contributors
  lib/model: Set platform data, incl. copying ownership, for new folders w/ NoPermissions flag (syncthing#8883)
  gui: Add Thai (th) translation template. (syncthing#8887)
  build: Produce nightly release builds
  gui, man, authors: Update docs, translations, and contributors
  build: Bump actions version; fix Node 12 deprecation warning (syncthing#8881)
  build: Build Debian packages
  build: Sign for upgrades
  build: Notarize mac builds
  build(deps): bump github.com/quic-go/quic-go from 0.33.0 to 0.34.0 (syncthing#8877)
  gui, man, authors: Update docs, translations, and contributors
  lib/ignore: Properly handle non-existing included ignore-files (fixes syncthing#8764) (syncthing#8874)
  lib/connections: Avoid using nil lanChecker
  gui, man, authors: Update docs, translations, and contributors
  lib/config, lib/connections: Configurable protocol priority (ref syncthing#8626) (syncthing#8868)
  build: Upgrade recli (fixes syncthing#8503) (syncthing#8871)
  build: Update dependencies (syncthing#8869)
  lib/model: Improve path generation for auto accepted folders (fixes syncthing#8859) (syncthing#8860)
  docs: fix typo (syncthing#8857)
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Apr 10, 2024
@syncthing syncthing locked and limited conversation to collaborators Apr 10, 2024
@calmh calmh deleted the autoacceptpath branch May 26, 2025 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@er-pa er-pa er-pa approved these changes

+1 more reviewer

@Ufkhan4386 Ufkhan4386 Ufkhan4386 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.23.5
Development

Successfully merging this pull request may close these issues.
4 participants
@calmh @er-pa @Ufkhan4386 @st-review