Skip to content

build: Update quic-go and pfilter for Go 1.20 (fixes #8768) #8769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2023
Merged

build: Update quic-go and pfilter for Go 1.20 (fixes #8768) #8769

merged 2 commits into from
Feb 2, 2023
+74 −250

Conversation

calmh
Copy link
Member

@calmh calmh commented Feb 2, 2023

No description provided.

@calmh calmh marked this pull request as ready for review February 2, 2023 08:55
@calmh
Copy link
Member Author

calmh commented Feb 2, 2023

There's a fascinating build failure on the discovery server. With this change, building on Go 1.19.5 for openbsd/mips64 crashes the compiler. This is reproducible in the golang:1.19.5 docker image on my own machine too.

root@cd53883ee685:/st# go run build.go -goos openbsd -goarch mips64 tar stdiscosrv
# github.com/syncthing/syncthing/cmd/stdiscosrv
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x15447c]

goroutine 1 [running]:
cmd/link/internal/ld.dynrelocsym(0x40000f6000, 0x1c018?)
	/usr/local/go/src/cmd/link/internal/ld/data.go:853 +0x28c
cmd/link/internal/ld.(*dodataState).dynreloc(0x4000c4e480, 0x40000f6000)
	/usr/local/go/src/cmd/link/internal/ld/data.go:871 +0x8c
cmd/link/internal/ld.(*Link).dodata(0x40000f6000, {0x4000fd8000, 0x4a384, 0x4a384})
	/usr/local/go/src/cmd/link/internal/ld/data.go:1498 +0x384
cmd/link/internal/ld.Main(_, {0x8, 0x20, 0x1, 0x1d, 0x1f, 0x0, {0x0, 0x0}, {0x271699, ...}, ...})
	/usr/local/go/src/cmd/link/internal/ld/main.go:336 +0x12f8
main.main()
	/usr/local/go/src/cmd/link/main.go:72 +0xe98
exit status 2
exit status 1
root@cd53883ee685:/st#

@calmh
Copy link
Member Author

calmh commented Feb 2, 2023

I filed an issue on Go and removed the openbsd/mips64 target for the discovery server...

imsodin
imsodin approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@imsodin imsodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting

@calmh calmh merged commit 99595ce into syncthing:main Feb 2, 2023
@calmh calmh deleted the go120 branch February 2, 2023 21:00
@chenrui333 chenrui333 mentioned this pull request Feb 4, 2023
Closed
Martchus pushed a commit to Martchus/syncthing that referenced this pull request Feb 7, 2023
@calmh @Martchus
build: Update quic-go and pfilter for Go 1.20 (fixes syncthing#8768) (s…
32e7b86 
…yncthing#8769)
@calmh calmh added this to the v1.23.2 milestone Feb 12, 2023
calmh added a commit to calmh/syncthing that referenced this pull request Feb 22, 2023
@calmh
Merge branch 'main' into linuxbuild
22f7807 
* main: (48 commits)
  build: Use Go 1.19.6 for Windows
  build: Update dependencies
  gui, man, authors: Update docs, translations, and contributors
  gui: Remove duplicate Spanish (Spain) translation (fixes syncthing#8781) (syncthing#8782)
  gui: Add xattr filter editor (fixes syncthing#8660) (syncthing#8734)
  gui: Switch to Weblate for translations (syncthing#8777)
  all: Use new Go 1.19 atomic types (syncthing#8772)
  gui, man, authors: Update docs, translations, and contributors
  build: Update quic-go and pfilter for Go 1.20 (fixes syncthing#8768) (syncthing#8769)
  Add forgotten copyright notices
  cmd, docker: Updates for infrastructure
  cmd/ursrv: The driver import is important, though
  cmd/ursrv: Remove old, unused migration code
  cmd/ursrv: Harmonize timespan of charts
  cmd/ursrv: Remove broken and unsustainable join/leave chart
  cmd/ursrv: Fix broken block transfer chart
  gui, man, authors: Update docs, translations, and contributors
  gui: Fix broken link to Transifex in lang/README.txt (syncthing#8761)
  gui, man, authors: Update docs, translations, and contributors
  Handle relay connect timeout (fixes syncthing#8749) (syncthing#8755)
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Feb 3, 2024
@syncthing syncthing locked and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@imsodin imsodin imsodin approved these changes

Assignees
No one assigned
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.23.2
Development

Successfully merging this pull request may close these issues.
3 participants
@calmh @imsodin @st-review