Skip to content

Conversation

tomasz1986
Copy link
Member

In large setups, it is currently impossible to know the exact number of folders and remote devices without counting them manually, either in the GUI or in config.xml. Thus, to provide this information to the user, add a specific number right next to both Folders and Remote Devices headers in the Web GUI. The numbers are only displayed when two or more folders or devices are present.

Signed-off-by: Tomasz Wilczyński twilczynski@naver.com

Screenshots

image

In large setups, it is currently impossible to know the exact number of
folders and remote devices without counting them manually, either in the
GUI or in config.xml. Thus, to provide this information to the user, add
a specific number right next to both Folders and Remote Devices headers
in the Web GUI. The numbers are only displayed when two or more folders
or devices are present.

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
@bt90
Copy link
Contributor

bt90 commented Oct 21, 2022

Neat!

@calmh calmh merged commit 8228020 into syncthing:main Oct 21, 2022
@tomasz1986 tomasz1986 deleted the tomasz86/gui/display-folderdevice-number branch October 21, 2022 14:27
@uok
Copy link
Contributor

uok commented Oct 21, 2022

I'm not a fan of all these edge cases lately ...
The average user has 3 devices and 2 folders (see https://data.syncthing.net/)
Maybe display it only on larger setups? Or show a summary (small font size) at end of list?

@acolomb
Copy link
Member

acolomb commented Oct 21, 2022

I'm not a fan of arbitrary limits to distinguish edge cases from "regular" usage. And I do have a lot of devices and folders 😉

But moving it to the bottom sounds sensible, I doubt that many people actually need the count displayed prominently. In file explorers, mail readers, etc. it's also customary to display such totals in the bottom status bar.

@tomasz1986
Copy link
Member Author

tomasz1986 commented Oct 21, 2022

Yeah, the information doesn't need to be right there in the headers, but I couldn't find any suitable place for it in the GUI without getting in the way of other elements (e.g. the buttons at the bottom) and also looking good visually. One alternative that I can think of could be to add this information to the table under "This Device", which already contains other details about the local state.

@calmh
Copy link
Member

calmh commented Oct 21, 2022

You guys, we don't need to bikeshed every simple change. It's a couple of metrics some will find useful, there's no real cost or downside, it's not a matter of pandering to weird edge cases.

@uok
Copy link
Contributor

uok commented Oct 22, 2022

Sorry not my intention. I just commented because I'm afraid that the next person wants "x syncing, y paused, z error" status.
Maybe a smaller font (e.g. small tag) and gray color could be a compromise as the number doesn't really change often.

@calmh calmh added this to the v1.22.1 milestone Oct 25, 2022
calmh added a commit to imsodin/syncthing that referenced this pull request Nov 8, 2022
* main: (36 commits)
  lib/protocol: Ignore inode time when xattr&ownership is ignored (fixes syncthing#8654) (syncthing#8655)
  lib/fs: Try to remove read only Windows files (fixes syncthing#3744) (syncthing#8650)
  gui: Add copy to clipboard, share by email, and share by SMS buttons to device IDs (fixes syncthing#2771, ref syncthing#3868) (syncthing#7984)
  gui, man, authors: Update docs, translations, and contributors
  build: Add GitHub actions build for Windows (syncthing#8627)
  gui: Fix connection type icon width (fixes syncthing#8592) (syncthing#8644)
  gui: Adjust connection type icon size scaling and alignment (syncthing#8645)
  docker: Use healthcheck endpoint (syncthing#8640)
  lib/connections: Use adaptive write size for rate limited connections (fixes syncthing#8630) (syncthing#8631)
  gui: Mark devices that haven't connected for a long time (fixes syncthing#7703) (syncthing#8530)
  gui: Fix rescan interval when add encrypted folder with watch for changes enabled (fixes syncthing#8570) (syncthing#8571)
  gui: Always show Out of Sync Items for remote devices (syncthing#8632)
  lib/fs: Let xattr test avoid non-test attributes (fixes syncthing#8601) (syncthing#8628)
  build: Add GitHub actions build for Windows
  gui, man, authors: Update docs, translations, and contributors
  gui: Display folder and device count number (syncthing#8615)
  gui, man, authors: Update docs, translations, and contributors
  lib/model, lib/protocol: Fix file comparisons (fixes syncthing#8594) (syncthing#8603)
  lib/scanner: More sensible debug output (syncthing#8596)
  gui: Allow automatic device ID selection on WebKit browsers (ref syncthing#8544) (syncthing#8597)
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Oct 21, 2023
@syncthing syncthing locked and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants