Fix linking to LLVM dylib #2075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
reviewed
Dec 31, 2024
Detect if LLVM has been built with the request to link to dylib,
and use dylib rather than trying to link components libs in that case.
This fixes undesirable static linking when static libraries are
installed, and an error when they are not.
Note that this probably is not the best way of handling the problem
(upstream recommends using something like `llvm_config(symengine
USE_SHARED ${SYMENGINE_LLVM_COMPONENTS})`) but it makes minimal changes
to the current complex logic, and therefore is least likely to break
something.
Fixes symengine#2074
isuruf
reviewed
Dec 31, 2024
isuruf
approved these changes
Dec 31, 2024
Co-authored-by: Isuru Fernando <isuruf@gmail.com>
|
Thanks |
mgorny
added a commit
to mgorny/symengine
that referenced
this pull request
Jul 20, 2025
This is a followup to symengine#2075 that fixes linking against LLVM dylib in reverse dependencies of SymEngine (e.g. the Python package). Unfortunately, my original patch missed this second occurrence. Given that we permit overriding the dylib use via a cache variable and it is unlikely for a dylib install to suddenly become non-dylib let's store the value in the config file. Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect if LLVM has been built with the request to link to dylib, and use dylib rather than trying to link components libs in that case. This fixes undesirable static linking when static libraries are installed, and an error when they are not.
Note that this probably is not the best way of handling the problem (upstream recommends using something like
llvm_config(symengine USE_SHARED ${SYMENGINE_LLVM_COMPONENTS})) but it makes minimal changes to the current complex logic, and therefore is least likely to break something.Fixes #2074