perf(es/minifier): Remove needless JSON conversion #10628
Conversation
|
| if (bindings) { | ||
| return bindings.minify(toBuffer(src), toBuffer(opts ?? {}), extras ?? {}); | ||
| return bindings.minify(Buffer.from(typeof src === 'object' ? JSON.stringify(src) : src), toBuffer(opts ?? {}), typeof src === 'object', extras ?? {}); |
There was a problem hiding this comment.
@kdy1
You widened the allowed type of src to include Buffer, in which case typeof src === 'object', which means if a caller passes a Buffer it will get stringified, which is going to make a mess. If you want to include Buffer in the allowed input types you'll want to handle it explicitly.
There was a problem hiding this comment.
Ah you are right
Thank you!
### What? Remove unnecessary JSON operations. ### Why? - swc-project/swc#10628 - swc-project/swc#10610
Description:
Related issue: