fix filtering symlinks in webdav methods #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9df1b1 to
66d855f
Compare
svenstaro
requested changes
Jun 26, 2025
| } | ||
| Box::pin(async move { | ||
| if !self.is_path_allowed(path).await { | ||
| return Err(DavFsError::NotFound); |
There was a problem hiding this comment.
Maybe log something here so it's a bit easier to debug?
| } else { | ||
| Box::pin(ready(Err(DavFsError::NotFound))) | ||
| } | ||
| Box::pin(async move { |
| } | ||
| Some(Ok(e)) | ||
| } | ||
| Err(e) => Some(Err(e)), |
There was a problem hiding this comment.
Hmmm is this right? Won't this result in weird entries? Also, should we log here?
| } | ||
| Box::pin(async move { | ||
| if !self.is_path_allowed(path).await { | ||
| Err(DavFsError::NotFound) |
svenstaro
added a commit
that referenced
this pull request
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows
--enable-webdavand--no-symlinksto be used together, and adds the necessary filtering.