Skip to content

Optional enable compression middleware to reduce response size (disabled by default) #1315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2024
Merged

Optional enable compression middleware to reduce response size (disabled by default) #1315

merged 2 commits into from
Jan 16, 2024

Conversation

zuisong
Copy link
Contributor

@zuisong zuisong commented Jan 14, 2024

#523
#497

This PR adds an optional section to turn on compress response, turned off by default, and a note in the help docs about the impact of turning this on.

/// Enable compress response
///
/// WARNING: Enabling this option may slow down transfers due to CPU overhead, so it is disabled by default.
/// 
/// Only enable this option if you know that your users have slow connections or if you want to minimize your server's bandwidth usage.

svenstaro
svenstaro requested changes Jan 15, 2024
View reviewed changes
Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a tiny code change.

Did you perform some benchmarks by any chance?

@zuisong
Copy link
Contributor Author

zuisong commented Jan 15, 2024

I didn't do benchmark, but my server egress bandwidth is very low, and I'm transmitting plain text files, which really need compression.

@zuisong zuisong requested a review from svenstaro January 15, 2024 08:13
svenstaro
svenstaro requested changes Jan 16, 2024
View reviewed changes
@svenstaro svenstaro merged commit 30addbf into svenstaro:master Jan 16, 2024
@svenstaro
Copy link
Owner

Super nice, thanks!

svenstaro added a commit that referenced this pull request Jan 16, 2024
@svenstaro
Add CHANGELOG entry for #1315
30c6aac
@zuisong zuisong deleted the opt_compress_response branch January 16, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenstaro svenstaro svenstaro requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zuisong @svenstaro @deantvv