Treat Unknown Tags with defined VL as OW #232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
suyashkumar
added a commit
that referenced
this pull request
Jun 9, 2024
* Interpret "" DICOM Character Set as iso-8859-1 (#219) * Treat Unknown Tags with defined VL as OW (#232) This change ensures that unknown tags with a defined VL are read as bytes (OW). This should fix #231. Previously they would have been read as strings by default. * Initial commit to default reading VR=UN as SQ when reading with an implicit transfer syntax and undefined length * add todo * handle all forms of unknown data elements * Update go version in build * update other go build versions --------- Co-authored-by: Yoshiyuki Harada <70787551+marineotter@users.noreply.github.com> Co-authored-by: Suyash Kumar <suyashkumar2003@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that unknown tags with a defined VL are read as bytes (OW). This should fix #231. Previously they would have been read as strings by default.