-
-
Notifications
You must be signed in to change notification settings - Fork 146
Comparing changes
Open a pull request
base repository: suyashkumar/dicom
base: v1.0.5
head repository: suyashkumar/dicom
compare: v1.0.6
- 14 commits
- 32 files changed
- 7 contributors
Commits on Jan 29, 2022
-
Treat Unknown Tags with defined VL as OW (#232)
This change ensures that unknown tags with a defined VL are read as bytes (OW). This should fix #231. Previously they would have been read as strings by default.
Configuration menu - View commit details
-
Copy full SHA for 965296c - Browse repository at this point
Copy the full SHA 965296cView commit details
Commits on Jul 5, 2022
-
Support padding byte when odd number of pixel data bytes (#233)
Co-authored-by: Suyash Kumar <suyashkumar2003@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 836cc53 - Browse repository at this point
Copy the full SHA 836cc53View commit details
Commits on Aug 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0528e8c - Browse repository at this point
Copy the full SHA 0528e8cView commit details
Commits on Sep 7, 2022
-
Allow option to tolerate PixelData VL and expected length mismatches. (…
…#245) This change introduces a ParseOption that allows PixelData element VL and expected lengths to mismatch without returning an error. If the given ParseOption is set, the PixelData with the aforementioned mismatch will have its raw bytes read, dropped into an encapsulated Frame, and have that Frame wrapped in a PixelDataInfo with a ParseErr property set to an error describing this scenario. (Commit description/summary set by suyashkumar@). Co-authored-by: quang18 <quang@segmed.ai>
Configuration menu - View commit details
-
Copy full SHA for 58fd583 - Browse repository at this point
Copy the full SHA 58fd583View commit details
Commits on Dec 23, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a4ded52 - Browse repository at this point
Copy the full SHA a4ded52View commit details -
Documentation: http → https (#249)
* chmod -x * Documentation: http → https
Configuration menu - View commit details
-
Copy full SHA for b667091 - Browse repository at this point
Copy the full SHA b667091View commit details
Commits on Jan 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d736099 - Browse repository at this point
Copy the full SHA d736099View commit details
Commits on Feb 20, 2023
-
Refactor read* methods into a lightweight reader struct. (#254)
This change wraps the read* methods in read.go into a lightweight reader struct. This allows for easier sharing of some common variables, for example the parse options set without having to inject them through deep read* call chains. This also does the following: * Moves readMetadata into read.go * removes parseOptSet from Dataset. * updates dicomio.NewReader signature to not include an error (not needed). We may want to revisit the naming of some of these entities at some point. There now exists a dicom.reader (unexported) and a lower level dicomio.Reader (referred to as rawReader in this change). Ideally we can also make future refactors to eliminate the need for Parser to be aware of the rawReader (should be easy).
Configuration menu - View commit details
-
Copy full SHA for a0d9656 - Browse repository at this point
Copy the full SHA a0d9656View commit details -
Configuration menu - View commit details
-
Copy full SHA for 954baa9 - Browse repository at this point
Copy the full SHA 954baa9View commit details -
Add option to skip Element Value processing of PixelData, while prese…
…rving roundtrip read/write (#256) This addresses _some_ of the discussion in #224. The SkipProcessingPixelDataValue option causes the PixelData bytes to be read into the element, but not processed any further. This option provides an option to save the CPU cycles processing NativePixel data but still gives a roundtrip-able Dataset. If you want to save both CPU and Memory, you can instead use the SkipPixelData option, which doesn't load the PixelData bytes into memory at all. In the future, we should consider an option to lazy load/process all Element values if possible.
Configuration menu - View commit details
-
Copy full SHA for 8bad20f - Browse repository at this point
Copy the full SHA 8bad20fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23307a8 - Browse repository at this point
Copy the full SHA 23307a8View commit details
Commits on Feb 23, 2023
-
Bump golang.org/x/text from 0.3.7 to 0.3.8 (#262)
Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.7...v0.3.8)
Configuration menu - View commit details
-
Copy full SHA for 5000f26 - Browse repository at this point
Copy the full SHA 5000f26View commit details -
Configuration menu - View commit details
-
Copy full SHA for cb27a34 - Browse repository at this point
Copy the full SHA cb27a34View commit details
Commits on Feb 26, 2023
-
Benchmark across Parse options, add memory benchmarking. (#264)
This change updates the Parse benchmark to operate across useful ParseOptions, adds memory benchmarking, and updates some benchmark params. For example, we can take a look at the CPU / memory differences across the new ParseOptions for one of the test dicoms: ``` BenchmarkParse/NoOptions/4.dcm-4 10 106876945 ns/op 120572543 B/op 2160 allocs/op BenchmarkParse/SkipPixelData/4.dcm-4 10 531193 ns/op 34900 B/op 2144 allocs/op BenchmarkParse/SkipProcessingPixelDataValue/4.dcm-4 10 1807256 ns/op 7573518 B/op 2146 allocs/op ```
Configuration menu - View commit details
-
Copy full SHA for 75975a5 - Browse repository at this point
Copy the full SHA 75975a5View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.0.5...v1.0.6