Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: suyashkumar/dicom
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.5
Choose a base ref
...
head repository: suyashkumar/dicom
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.6
Choose a head ref
  • 14 commits
  • 32 files changed
  • 7 contributors

Commits on Jan 29, 2022

  1. Treat Unknown Tags with defined VL as OW (#232)

    This change ensures that unknown tags with a defined VL are read as bytes (OW). This should fix #231. Previously they would have been read as strings by default.
    suyashkumar authored Jan 29, 2022
    Configuration menu
    Copy the full SHA
    965296c View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Support padding byte when odd number of pixel data bytes (#233)

    Co-authored-by: Suyash Kumar <suyashkumar2003@gmail.com>
    jabillings and suyashkumar authored Jul 5, 2022
    Configuration menu
    Copy the full SHA
    836cc53 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Update go to 1.18 (#244)

    suyashkumar authored Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0528e8c View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Allow option to tolerate PixelData VL and expected length mismatches. (

    …#245)
    
    This change introduces a ParseOption that allows PixelData element VL and expected lengths to mismatch without returning an error. If the given ParseOption is set, the PixelData with the aforementioned mismatch will have its raw bytes read, dropped into an encapsulated Frame, and have that Frame wrapped in a PixelDataInfo with a ParseErr property set to an error describing this scenario. 
    
    (Commit description/summary set by suyashkumar@).
    
    Co-authored-by: quang18 <quang@segmed.ai>
    ducquangkstn and quang18 authored Sep 7, 2022
    Configuration menu
    Copy the full SHA
    58fd583 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Configuration menu
    Copy the full SHA
    a4ded52 View commit details
    Browse the repository at this point in the history
  2. Documentation: http → https (#249)

    * chmod -x
    
    * Documentation: http → https
    DimitriPapadopoulos authored Dec 23, 2022
    Configuration menu
    Copy the full SHA
    b667091 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Add Fuzz test (#252)

    jesslatimer authored Jan 28, 2023
    Configuration menu
    Copy the full SHA
    d736099 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Refactor read* methods into a lightweight reader struct. (#254)

    This change wraps the read* methods in read.go into a lightweight reader struct. This allows for easier sharing of some common variables, for example the parse options set without having to inject them through deep read* call chains. 
    
    This also does the following: 
    
    * Moves readMetadata into read.go
    *  removes parseOptSet from Dataset.
    * updates dicomio.NewReader signature to not include an error (not needed). 
    
    
    We may want to revisit the naming of some of these entities at some point. There now exists a dicom.reader (unexported) and a lower level dicomio.Reader (referred to as rawReader in this change). Ideally we can also make future refactors to eliminate the need for Parser to be aware of the rawReader (should be easy).
    suyashkumar authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    a0d9656 View commit details
    Browse the repository at this point in the history
  2. Introduce option to SkipPixelData (#255)

    This introduces an option to SkipPixelData processing, making use of the new reader struct introduced in #254.
    
    See also, review discussion in #243 that helped motivate the changes I wanted to make in #254.
    suyashkumar authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    954baa9 View commit details
    Browse the repository at this point in the history
  3. Add option to skip Element Value processing of PixelData, while prese…

    …rving roundtrip read/write (#256)
    
    This addresses _some_ of the discussion in #224. The SkipProcessingPixelDataValue option causes the PixelData bytes to be read into the element, but not processed any further. This option provides an option to save the CPU cycles processing NativePixel data but still gives a roundtrip-able Dataset.
    
    If you want to save both CPU and Memory, you can instead use the SkipPixelData option, which doesn't load the PixelData bytes into memory at all.
    
    In the future, we should consider an option to lazy load/process all Element values if possible.
    suyashkumar authored Feb 20, 2023
    Configuration menu
    Copy the full SHA
    8bad20f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    23307a8 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. Bump golang.org/x/text from 0.3.7 to 0.3.8 (#262)

    Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.3.8.
    - [Release notes](https://github.com/golang/text/releases)
    - [Commits](golang/text@v0.3.7...v0.3.8)
    dependabot[bot] authored Feb 23, 2023
    Configuration menu
    Copy the full SHA
    5000f26 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb27a34 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2023

  1. Benchmark across Parse options, add memory benchmarking. (#264)

    This change updates the Parse benchmark to operate across useful ParseOptions, adds memory benchmarking, and updates some benchmark params. 
    
    For example, we can take a look at the CPU / memory differences across the new ParseOptions for one of the test dicoms:
    ```
    BenchmarkParse/NoOptions/4.dcm-4                                     	      10	 106876945 ns/op	120572543 B/op	    2160 allocs/op
    BenchmarkParse/SkipPixelData/4.dcm-4                                 	      10	    531193 ns/op	   34900 B/op	    2144 allocs/op
    BenchmarkParse/SkipProcessingPixelDataValue/4.dcm-4                  	      10	   1807256 ns/op	 7573518 B/op	    2146 allocs/op
    ```
    suyashkumar authored Feb 26, 2023
    Configuration menu
    Copy the full SHA
    75975a5 View commit details
    Browse the repository at this point in the history
Loading