Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: suyashkumar/dicom
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.4
Choose a base ref
...
head repository: suyashkumar/dicom
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.5
Choose a head ref
  • 3 commits
  • 7 files changed
  • 3 contributors

Commits on Aug 22, 2021

  1. Add initial support for bitsAllocated=1 (#212)

    This adds initial support for bitsAllocated=1 assuming LittleEndian ordering.
    
    I'm not sure if we should be assuming LittleEndian ordering all the time, but this appears to be consistent with pydicom's approach [1] and passes tests even for data that I attempted to write out as BigEndian (probably needs closer scrutiny in the future).
    
    This will address #211 for the case bitsAllocated = 1.
    
    [1] https://github.com/pydicom/pydicom/blob/f9ee9126fa8aa10c72dc1083d7aa53062b9ab6af/pydicom/pixel_data_handlers/numpy_handler.py#L186
    suyashkumar authored Aug 22, 2021
    Configuration menu
    Copy the full SHA
    a3cee26 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2021

  1. Introduce element-by-element Writer API, add SkipMetadataReadOnNewPar…

    …serInit Parser Option, add ParseOptions to Parser API. (#208)
    
    This change introduces an element-by-element Writer API, adds support for Parse Options (similar in structure to the WriteOption) and adds a SkipMetadataReadOnNewParserInit option. 
    
    Co-authored-by: Suyash Kumar <suyashkumar2003@gmail.com>
    kristianvalind and suyashkumar authored Sep 26, 2021
    Configuration menu
    Copy the full SHA
    cd30440 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Configuration menu
    Copy the full SHA
    87c7d7e View commit details
    Browse the repository at this point in the history
Loading