-
Notifications
You must be signed in to change notification settings - Fork 516
feat: add sign in with ethereum #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
reviewed
Jul 7, 2025
hf
reviewed
Jul 7, 2025
hf
reviewed
Jul 7, 2025
hf
reviewed
Jul 7, 2025
hf
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just beautiful!
…es for SIWE messages
- Fix Nil date validation. - Fix remaining web3 tests. - Add ethereum enum/example to openapi.yml
- Added Ethereum config to example.env
change name of ChainFormatF
…se in implementation & testing.
…erification process.
4600a97
to
84ff3cd
Compare
Pull Request Test Coverage Report for Build 16317115832Details
💛 - Coveralls |
hf
pushed a commit
to supabase/auth-js
that referenced
this pull request
Jul 23, 2025
## What kind of change does this PR introduce? This PR adds SIWE (Sign-In-With-Ethereum) support to auth-js, related to [this PR on /auth](supabase/auth#2069) ## What is the current behavior? Multiple providers & SIWS (Solana) supported ## What is the new behavior? Add SIWE (Ethereum) support. ## Additional context The types are inspired by the the [viem](https://viem.sh/) library, which has minimal & modern types, but they were simplified and copied over to the local code to remove dependency on it.
cemalkilic
pushed a commit
that referenced
this pull request
Aug 6, 2025
🤖 I have created a release *beep* *boop* --- ## [2.178.0](v2.177.0...v2.178.0) (2025-08-05) ### Features * add sign in with ethereum ([#2069](#2069)) ([079b242](079b242)) * add support for managing SSO providers by resource_id ([#2081](#2081)) ([5ca4489](5ca4489)) * log all audit events separately to prevent missing events ([#2086](#2086)) ([3b666f5](3b666f5)) * skip nonce check for Facebook Limited Login auth ([#2082](#2082)) ([f1b15ff](f1b15ff)) * support ledger solana offchain message signing ([#2093](#2093)) ([4c94443](4c94443)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cemalkilic
pushed a commit
that referenced
this pull request
Aug 7, 2025
Adds Sign in with Ethereum. Configure it by: ``` GOTRUE_EXTERNAL_WEB3_ETHEREUM_ENABLED="true" GOTRUE_EXTERNAL_WEB3_ETHEREUM_MAXIMUM_VALIDITY_DURATION="10m" ``` SIWS & SIWE are based off of EIP-4361, which is referenced here: https://eips.ethereum.org/EIPS/eip-4361, so they are close in implementation with slight differences between address/signature verification format & algorithm. For Ethereum, specifically the signature verification part, It requires recovering the public address from the signature, and then testing the signature against it, with the algorithm Ethereum uses, this is tedious to implement without using the https://github.com/ethereum/go-ethereum package, as the verification has some error correction that it does, would be hard to test/maintain without the dependency, let me know what you think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Sign in with Ethereum. Configure it by:
SIWS & SIWE are based off of EIP-4361, which is referenced here: https://eips.ethereum.org/EIPS/eip-4361, so they are close in implementation with slight differences between address/signature verification format & algorithm.
For Ethereum, specifically the signature verification part, It requires recovering the public address from the signature, and then testing the signature against it, with the algorithm Ethereum uses, this is tedious to implement without using the https://github.com/ethereum/go-ethereum package, as the verification has some error correction that it does, would be hard to test/maintain without the dependency, let me know what you think.