-
Notifications
You must be signed in to change notification settings - Fork 351
Portal restructuring #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
} | ||
|
||
// get the path and set it on the request | ||
$this->setPath( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danrot ... maybe something like setResourceLocator(Path) would be more expressive and I think we need a resourceLocatorPrefix in future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course, that's a much better name. What would you understand by a resourceLocatorPrefix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have a language or a segment placeholder within the url path, it would be fine to know this prefix for e.g. setup the navigation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Therefore you have the current portal url (this one already contains the language and segment).
[BUGFIX] fixed redirect address after login
[BUGFIX] fixed redirect address after login
* added configuration for overriding ongr-document * refactored naming
…-entities Move var folder in composer.json
* Change cookie name to SULUSESSID * Update comment
Restructured the entire portal part