Skip to content

Portal restructuring #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Dec 3, 2013
Merged

Portal restructuring #21

merged 38 commits into from
Dec 3, 2013

Conversation

danrot
Copy link
Contributor

@danrot danrot commented Nov 27, 2013

Restructured the entire portal part

  • test coverage
  • finish the code
  • gather feedback for my changes
  • submit changes to the documentation
Q A
Bug fix? no
New feature? yes
Tests pass? yes
Fixed tickets no
Doc https://github.com/sulu-cmf/docs/blob/master/detail-specification/000-foundation/DET-004-Routing.md https://github.com/sulu-cmf/docs/blob/master/developer-documentation/000-foundation/workspaces.md

@danrot danrot mentioned this pull request Nov 28, 2013
3 tasks
}

// get the path and set it on the request
$this->setPath(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danrot ... maybe something like setResourceLocator(Path) would be more expressive and I think we need a resourceLocatorPrefix in future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course, that's a much better name. What would you understand by a resourceLocatorPrefix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a language or a segment placeholder within the url path, it would be fine to know this prefix for e.g. setup the navigation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Therefore you have the current portal url (this one already contains the language and segment).

@chirimoya chirimoya merged commit 18a3ef3 into develop Dec 3, 2013
@chirimoya chirimoya deleted the feature/portal-restructuring branch December 3, 2013 14:12
chirimoya added a commit that referenced this pull request Aug 14, 2014
[BUGFIX] fixed redirect address after login
chirimoya added a commit that referenced this pull request Oct 31, 2014
[BUGFIX] fixed redirect address after login
wachterjohannes added a commit to wachterjohannes/sulu that referenced this pull request May 8, 2017
* added configuration for overriding ongr-document

* refactored naming
GlennVL91 pushed a commit to Tactics/sulu that referenced this pull request Jun 20, 2019
…-entities

Move var folder in composer.json
@danrot danrot mentioned this pull request Sep 30, 2020
5 tasks
alexander-schranz added a commit to alexander-schranz/sulu that referenced this pull request Feb 22, 2024
* Change cookie name to SULUSESSID

* Update comment
alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this pull request Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants