Skip to content

Feature/api changes #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Dec 3, 2013
Merged

Feature/api changes #19

merged 15 commits into from
Dec 3, 2013

Conversation

turbo-ele
Copy link
Contributor

making adaptions for HAL API

  • new route for api
  • gather feedback for my changes
  • submit changes to the documentation

still open: bug in fosrestbundle makes it mandatory to use pluralization in translationsController (which means that renaming this controller is currently not possible)

Q A
Bug fix? no
New feature? yes
Tests pass? yes
Fixed tickets none
Doc [url to doc

// if no apiPath is not set generate it from basepath
if(is_null($this->getApiPath())) {
$class = explode('\\', get_class($this));
$this->apiPath = $this->apiBasePath.'/'.strtolower(end($class)).'s';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbo-ele maybe we can use the doctrine inflector here? Then we won't have any problems with words using a different plural form.

@@ -69,6 +69,12 @@ class ListQueryBuilder
*/
private $searchFields;


/**
* @var
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbo-ele please add more information in php docs

@danrot
Copy link
Contributor

danrot commented Dec 2, 2013

@turbo-ele I am missing some tests for checking if the hal links are correct

@danrot danrot merged commit 4a7cc0b into develop Dec 3, 2013
@danrot danrot deleted the feature/api-changes branch December 3, 2013 14:29
wachterjohannes added a commit that referenced this pull request Aug 14, 2014
added tooltips to permission matrix
wachterjohannes added a commit that referenced this pull request Aug 14, 2014
turbo-ele added a commit that referenced this pull request Aug 14, 2014
chirimoya added a commit that referenced this pull request Aug 14, 2014
chirimoya added a commit that referenced this pull request Aug 14, 2014
[FEATURE] add animated gif support
chirimoya added a commit that referenced this pull request Sep 30, 2014
…toring

[FEATURE] updated ContentNavigation
wachterjohannes added a commit that referenced this pull request Oct 31, 2014
added tooltips to permission matrix
wachterjohannes added a commit that referenced this pull request Oct 31, 2014
turbo-ele added a commit that referenced this pull request Oct 31, 2014
chirimoya added a commit that referenced this pull request Oct 31, 2014
chirimoya added a commit that referenced this pull request Oct 31, 2014
[FEATURE] add animated gif support
chirimoya added a commit that referenced this pull request Oct 31, 2014
…toring

[FEATURE] updated ContentNavigation
dantleech added a commit that referenced this pull request Oct 31, 2014
wachterjohannes added a commit to wachterjohannes/sulu that referenced this pull request May 8, 2017
* implemented editable route-path

* fixed comments
GlennVL91 pushed a commit to Tactics/sulu that referenced this pull request Jun 20, 2019
alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this pull request Feb 22, 2024
alexander-schranz pushed a commit to alexander-schranz/sulu that referenced this pull request Nov 25, 2024
…erage check (sulu#19)

* refactored circleci configuration

* exclude vendor folder from coverage report, add coverae-checker script

* added lint script in composer.json

* added artifacts and test-result configuration

* use regex to find path in coverage-checker

* automatically fixed coding style with php-cs

* add sleep to wait for mysql container

* adjusted composer cache config

* adjusted test-report paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants