-
Notifications
You must be signed in to change notification settings - Fork 351
Feature/api changes #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d sortable to template,
… select in querybuilder;
// if no apiPath is not set generate it from basepath | ||
if(is_null($this->getApiPath())) { | ||
$class = explode('\\', get_class($this)); | ||
$this->apiPath = $this->apiBasePath.'/'.strtolower(end($class)).'s'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turbo-ele maybe we can use the doctrine inflector here? Then we won't have any problems with words using a different plural form.
@@ -69,6 +69,12 @@ class ListQueryBuilder | |||
*/ | |||
private $searchFields; | |||
|
|||
|
|||
/** | |||
* @var |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turbo-ele please add more information in php docs
@turbo-ele I am missing some tests for checking if the hal links are correct |
added tooltips to permission matrix
implemented redirect for partial match
[FEATURE] add animated gif support
…toring [FEATURE] updated ContentNavigation
added tooltips to permission matrix
implemented redirect for partial match
[FEATURE] add animated gif support
…toring [FEATURE] updated ContentNavigation
* implemented editable route-path * fixed comments
Fix deprecated parameter usage
…erage check (sulu#19) * refactored circleci configuration * exclude vendor folder from coverage report, add coverae-checker script * added lint script in composer.json * added artifacts and test-result configuration * use regex to find path in coverage-checker * automatically fixed coding style with php-cs * add sleep to wait for mysql container * adjusted composer cache config * adjusted test-report paths
making adaptions for HAL API
still open: bug in fosrestbundle makes it mandatory to use pluralization in translationsController (which means that renaming this controller is currently not possible)