Listener for setting current portal #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problem solved, ready to merge |
|
@drotter ... please review checklist. test coverage? submitted changes to documentation? |
|
Sry, was a little bit hectical on tuesday... There are no tests and documentation yet... I'll try to work on that on the weekend. |
|
@chirimoya Now it should be mergeable. |
chirimoya
added a commit
that referenced
this pull request
Nov 18, 2013
Listener for setting current portal
|
@drotter ... merged |
wachterjohannes
added a commit
that referenced
this pull request
Aug 14, 2014
chirimoya
added a commit
that referenced
this pull request
Aug 14, 2014
…fault adjusted PortalRouteProvider to match new RequestAnalyzer
chirimoya
added a commit
that referenced
this pull request
Sep 30, 2014
Feature/translation suggestion
chirimoya
added a commit
that referenced
this pull request
Oct 31, 2014
Feature/translation suggestion
wachterjohannes
added a commit
that referenced
this pull request
Oct 31, 2014
chirimoya
added a commit
that referenced
this pull request
Oct 31, 2014
…fault adjusted PortalRouteProvider to match new RequestAnalyzer
wachterjohannes
pushed a commit
to wachterjohannes/sulu
that referenced
this pull request
May 8, 2017
* add medias with title, url and thumbnails to index * fix tests for media and fix author test
GlennVL91
pushed a commit
to Tactics/sulu
that referenced
this pull request
Jun 20, 2019
Reference: https://github.com/symfony/symfony-standard/blob/master/app/AppKernel.php#L43 If the purpose is easy maintainability of the cache and log dirs please ignore my PR. However, I think it's better to align with Symfony behaviour.
alexander-schranz
added a commit
to alexander-schranz/sulu
that referenced
this pull request
Feb 22, 2024
* Remove image formats xml in public folder * Run agains dev-release/2.0
alexander-schranz
pushed a commit
to alexander-schranz/sulu
that referenced
this pull request
Nov 25, 2024
* Add "DuplicateContentMessage" * Finish functional test * Fix test * Register service * Fix bug * Use correct method * Fix bug * Add DuplicateExcerptMessage * Add DuplicateSeoMessage * Fix php-cs and phpstan * Add message unit tests * Add message handler unit test * Add tests * Add createClone unit tests * Add createClone unit test * Better unit test * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a listener for setting the current portal
@chirimoya The listener is called after the RouteProvider, so we have to call the
findByUrl-method twice (RouteProvider + KernelListener). I don't really want to set the current Portal in theRouteProvider....