Add RLP Strategies for URL generation #14
Conversation
|
@drotter there is no load method in rlpmapper and rlpstrategy |
|
|
||
| use Exception; | ||
|
|
||
| class ResourceLocatorNotExistsException extends Exception |
There was a problem hiding this comment.
@wachterjohannes ... I would prefer NotFoundException
There was a problem hiding this comment.
@chirimoya we have build our own exception class tree for rest api! I think you should use the everywhere?
There was a problem hiding this comment.
@wachterjohannes Sorry, maybe my comment was misleading. A own exception is fine, but I would choose another name: ResourceLocatorNotFoundException (also the server must respond with a 404 not found)
There was a problem hiding this comment.
@chirimoya @drotter FIXED: cc912ad
| * @param $language string read data for given language | ||
| * @return StructureInterface | ||
| */ | ||
| public function read($id, $language) | ||
| public function load($id, $portal, $language) |
There was a problem hiding this comment.
@wachterjohannes ... to be consistent use $uuid instead $id? /cc @drotter
There was a problem hiding this comment.
@chirimoya @drotter FIXED: 3d66053
|
@chirimoya ready to merge |
[FEATURE] Introduced TestContact
Always index webspaceKey
Updated to new bundle structure
Updated to new bundle structure
[FEATURE] Introduced TestContact
Always index webspaceKey
* immplemented by-type and by-template route-generator * fixed testcases to fit new sulu * added tests for custom-route-generators * changed config from service-id to alias * changed alias of route_generators * changed alias of route_generators
Add RLP Strategies for URL generation: