Skip to content

Add at-page support to selector-pseudo-class-no-unknown #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2017
Merged

Add at-page support to selector-pseudo-class-no-unknown #2445

merged 1 commit into from
Apr 16, 2017

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Mar 27, 2017 •
edited
Loading

Which issue, if any, is this issue related to?

#1871

Is there anything in the PR that needs further explanation?

No, it's self explanatory.

If the solution is appropriate, then I will add similar logic to other rules 😄

jeddy3
jeddy3 reviewed Mar 28, 2017
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good addition as it doesn't seem to add too much more complexity.

@alexander-akait
Copy link
Member Author

@jeddy3 good, in near future i add this to another rules 😄

@davidtheclark
Copy link
Contributor

👍

@jeddy3
Copy link
Member

jeddy3 commented Mar 30, 2017

good, in near future i add this to another rules 😄

@evilebottnawi Do you want to do that in this PR? Or shall we merge this one?

@alexander-akait
Copy link
Member Author

@jeddy3 How will be better? 😄

@jeddy3
Copy link
Member

jeddy3 commented Mar 30, 2017

@jeddy3 How will be better? 😄

I guess merging this now means the PR won't linger.

We should create new issues for the other rules you intend to update.

@alexander-akait
Copy link
Member Author

@jeddy3 good

@jeddy3 jeddy3 changed the title Enhancement: PoC support page at-rule. Add at-page support to selector-pseudo-class-no-unknown Apr 1, 2017
davidtheclark
davidtheclark approved these changes Apr 16, 2017
View reviewed changes
Copy link
Contributor

@davidtheclark davidtheclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍨

@davidtheclark davidtheclark merged commit 669ca6b into master Apr 16, 2017
@davidtheclark davidtheclark deleted the issue-1871 branch April 16, 2017 15:00
@davidtheclark
Copy link
Contributor

Added to changelog:

  • Fixed: selector-pseudo-class-no-unknown now checks @page at-rules and supports @page pseudo-classes (#2445).

@renovate renovate bot mentioned this pull request Jun 9, 2017
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 14, 2018
Closed
@Mouvedia Mouvedia mentioned this pull request Dec 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtheclark davidtheclark davidtheclark approved these changes

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexander-akait @davidtheclark @jeddy3