Fix custom-property-pattern false negatives for @property preludes
#8468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 683a0ef The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Try the Instant Preview in Online DemoInstall the Instant Preview to Your Local |
ybiquitous
requested changes
Mar 14, 2025
…erty at-rule names and add test cases (closes stylelint#8430)
@property preludes
@property preludescustom-property-pattern false negatives for @property preludes
ybiquitous
requested changes
Mar 14, 2025
…ts (closes stylelint#8430) - Removed unnecessary typeof additions. - Use shared regex (atRuleRegexes.propertyName) to support both lower/upper cases. - Simplified error index calculation for @Property rules by using atRuleParamIndex utility. - Added an empty line in the @Property block for clarity. - Simplified test CSS for @Property rules (e.g. '@Property --foo-bar {}') to focus on core syntax. This refactor addresses reviewer suggestions and improves code clarity and maintainability.
…loses stylelint#8430) Forgot to remove the leftover typeof additions from the code. This change cleans up the code, ensuring we only use the shared utilities and simplify the @Property handling logic as suggested.
ybiquitous
reviewed
Mar 16, 2025
closes stylelint#8430) Removed the "extra" parameter from the complain function since it is no longer needed after simplifying the error location calculation. This further streamlines the code and improves clarity.
jeddy3
reviewed
Mar 16, 2025
There was a problem hiding this comment.
@rohitgs28 Thanks for making @ybiquitous suggested changes.
I've requested a couple more minor ones related to our code conventions. Otherwise, looking good thank you.
rohitgs28
commented
Mar 16, 2025
| @@ -70,19 +69,26 @@ const rule = (primary) => { | |||
|
|
|||
| complain(0, prop, decl); | |||
| }); | |||
| root.walkAtRules(atRuleRegexes.propertyName, (atRule) => { | |||
jeddy3
reviewed
Mar 16, 2025
|
@rohitgs28 Thank you for your first contribution to Stylelint 🎉 |
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 28, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.16.0 | 16.17.0 | ## [v16.17.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16170---2025-03-26) It adds 1 new rule, support for `languageOptions` to 2 rules, 1 option to a rule, the `--compute-edit-info` CLI flag (along with support for `EditInfo` in 3 rules), and fixes 1 bug. `EditInfo` is useful for automated fixing tools and editor integrations. - Added: `layer-name-pattern` rule ([#8474](stylelint/stylelint#8474)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `--compute-edit-info` CLI flag ([#8473](stylelint/stylelint#8473)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `ignorePreludeOfAtRules: []` to `length-zero-no-unit` ([#8472](stylelint/stylelint#8472)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-no-unknown` support for `languageOptions` ([#8475](stylelint/stylelint#8475)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `property-no-unknown` support for `languageOptions` ([#8476](stylelint/stylelint#8476)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `declaration-block-no-redundant-longhand-properties` support for computing `EditInfo` ([#8482](stylelint/stylelint#8482)) ([@pamelalozano16](https://github.com/pamelalozano16)). - Added: `function-url-quotes` support for computing `EditInfo` ([#8483](stylelint/stylelint#8483)) ([@pamelalozano16](https://github.com/pamelalozano16)). - Added: `selector-attribute-quotes` support for computing `EditInfo` ([#8484](stylelint/stylelint#8484)) ([@pamelalozano16](https://github.com/pamelalozano16)). - Fixed: `custom-property-pattern` false negatives for `@property` preludes ([#8468](stylelint/stylelint#8468)) ([@rohitgs28](https://github.com/rohitgs28)).
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Mar 28, 2025
| datasource | package | from | to | | ---------- | --------- | ------- | ------- | | npm | stylelint | 16.16.0 | 16.17.0 | ## [v16.17.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16170---2025-03-26) It adds 1 new rule, support for `languageOptions` to 2 rules, 1 option to a rule, the `--compute-edit-info` CLI flag (along with support for `EditInfo` in 3 rules), and fixes 1 bug. `EditInfo` is useful for automated fixing tools and editor integrations. - Added: `layer-name-pattern` rule ([#8474](stylelint/stylelint#8474)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `--compute-edit-info` CLI flag ([#8473](stylelint/stylelint#8473)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `ignorePreludeOfAtRules: []` to `length-zero-no-unit` ([#8472](stylelint/stylelint#8472)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `at-rule-no-unknown` support for `languageOptions` ([#8475](stylelint/stylelint#8475)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `property-no-unknown` support for `languageOptions` ([#8476](stylelint/stylelint#8476)) ([@ryo-manba](https://github.com/ryo-manba)). - Added: `declaration-block-no-redundant-longhand-properties` support for computing `EditInfo` ([#8482](stylelint/stylelint#8482)) ([@pamelalozano16](https://github.com/pamelalozano16)). - Added: `function-url-quotes` support for computing `EditInfo` ([#8483](stylelint/stylelint#8483)) ([@pamelalozano16](https://github.com/pamelalozano16)). - Added: `selector-attribute-quotes` support for computing `EditInfo` ([#8484](stylelint/stylelint#8484)) ([@pamelalozano16](https://github.com/pamelalozano16)). - Fixed: `custom-property-pattern` false negatives for `@property` preludes ([#8468](stylelint/stylelint#8468)) ([@rohitgs28](https://github.com/rohitgs28)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #8430, where the custom-property-pattern rule was not reporting the correct error location for custom property names declared via @Property at-rules.
Changes
In
lib/rules/custom-property-pattern/index.mjs, the error location calculation for @Property at-rules has been adjusted. The fix computes the base error index using the at-rule’s source column plus an offset (and optionally adds an extra offset for property names ending with a hyphen) so that the reported start and end columns match the expected values.New test cases were added to
lib/rules/custom-property-pattern/__tests__/index.mjsto ensure that:--foo-bar) passes.--Foo-barwith an uppercase letter or--foo-for an incomplete name) are flagged with the correct error location.Testing
npm run build.npm testand confirmed that all tests pass and the error locations in @Property at-rules now match the expected snapshots.Closes #8430.
Please let me know if any further changes are required.