Respect current existing env var in build_info.py #6906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9ae8460 to
5eb3b29
Compare
kmcgrady
approved these changes
Jun 27, 2023
vdonato
approved these changes
Jul 7, 2023
sfc-gh-mnowotka
approved these changes
Jul 10, 2023
0e20e16 to
4399e65
Compare
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Jul 10, 2023
* develop: Respect current existing env var in build_info.py (streamlit#6906) fix: frontend/package.json & frontend/yarn.lock to reduce vulnerabilities (streamlit#6959) Update hamburger menu icon to overflow (streamlit#6947) Fix: description of config options (streamlit#6917) Add missing border radius (streamlit#6944) Up version to 1.24.0 (streamlit#6905) modify st.echo to use ast to handle indenting properly (streamlit#5375)
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If the variables are set in the workflow.yaml file, then we should no longer change them via the script.
streamlit/.github/workflows/release.yml
Lines 61 to 62 in c7f9791
GitHub Issue Link (if applicable)
Testing Plan
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.