Add color_util.py, which will be used by native charts in next few PRs. #6826

sfc-gh-tteixeira · 2023-06-12T19:09:29Z

Describe your changes

Introduce a library for handling/converting colors in Python. This library isn't used yet, but it will be in a couple of follow-up PRs. The reason I'm sending this PR this way is to make it easier to review all the code!

This is part of the work to:

Add a color argument to our native charts
Add latitude, longitude, color, and size to to st.map
Add st.scatter_chart

GitHub Issue Link (if applicable)

None

Testing Plan

Explanation of why no additional tests are needed
n/a
Unit Tests (JS and/or Python)
✅
E2E Tests
n/a
Any manual testing needed?
No. This isn't library connected to anything right now

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

lib/streamlit/color_util.py

willhuang1997 · 2023-06-23T22:13:09Z

I see some failure on type checking for python but I personally don't understand why it's failing when the length is 4 and it should have a 4th element. However, I added the labels for the pull request so that should fulfill some of the github actions checks!

I asked chat-gpt and it gave me a terrible response 😆

if len(color) == 3:
    r = rgb_formatter(color[0], color)
    g = rgb_formatter(color[1], color)
    b = rgb_formatter(color[2], color)
    return r, g, b

elif len(color) == 4:
    r = rgb_formatter(color[0], color)
    g = rgb_formatter(color[1], color)
    b = rgb_formatter(color[2], color)
    if len(color) == 4:
        alpha = alpha_formatter(color[3], color)
        return r, g, b, alpha
    else:
        # Handle the case when len(color) is not 4
        # This could be an error condition or a default value for alpha
        # Return or assign an appropriate value based on your requirements
        return r, g, b, None  # Example: returning None as a default value

sfc-gh-tteixeira · 2023-06-23T23:02:49Z

I see some failure on type checking for python (...)

Fixed by casting to a 4-tuple.

lib/streamlit/color_util.py

* develop: Add color_util.py, which will be used by native charts in next few PRs. (streamlit#6826)

…s. (streamlit#6826) * Add color_util.py, which will be used by native charts in next few PRs. * Trying to fix typing * Fix color_util typing * Output tuples * Small code adjustments, plus typing improvements * Cleaning up some code * Resolve comments. * Better comments.

Add color_util.py, which will be used by native charts in next few PRs.

22b76dc

github-advanced-security bot found potential problems Jun 12, 2023

View reviewed changes

lib/streamlit/color_util.py Fixed Show fixed Hide fixed

sfc-gh-tteixeira added 4 commits June 22, 2023 10:45

Trying to fix typing

4eb40ca

Merge remote-tracking branch 'origin/develop' into color_util

4cc5f6b

Fix color_util typing

0cc9374

Output tuples

7de0609

sfc-gh-tteixeira marked this pull request as ready for review June 22, 2023 23:05

sfc-gh-tteixeira requested a review from willhuang1997 June 23, 2023 16:38

sfc-gh-tteixeira added 3 commits June 23, 2023 09:44

Small code adjustments, plus typing improvements

2a2f12a

Merge remote-tracking branch 'origin/develop' into color_util

2c509a0

Cleaning up some code

dcafee5

willhuang1997 added change:other impact:internal security-assessment-completed labels Jun 23, 2023

willhuang1997 reviewed Jun 23, 2023

View reviewed changes

lib/streamlit/color_util.py Outdated Show resolved Hide resolved

willhuang1997 reviewed Jun 23, 2023

View reviewed changes