"client.showErrorDetails" controls whether deprecation warnings appear in-browser #5945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! If I understand correctly (please correct me if I am wrong), we override If this is correct I believe we will have desired behavior in most of the cloud apps, except for applications in which the |
kajarenc
approved these changes
Jan 12, 2023
Yeah exactly! |
eric-skydio
pushed a commit
to eric-skydio/streamlit
that referenced
this pull request
Dec 20, 2023
…r in-browser (streamlit#5945) With the incoming `@st.cache` deprecation, we're going to see a lot of apps with a lot of deprecation warnings. Currently, we show deprecation warnings in the browser, which is convenient for an app's developer - but sucks for app viewers. With this PR, we will now only print deprecation warnings to the browser when `"client.showErrorDetails"=True`. This config option is currently used to suppress app exception tracebacks from being printed to the browser, so this is a slight overloading of its original purpose - but it feels appropriate (the circumstance where you don't want to loudly display exception tracebacks - when you have a deployed app - is exactly the same as when you don't want to display deprecation warnings). Deprecation warnings now also always get logged to the console, so developers will see them in their logs regardless of whether they're displayed in-browser.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Mar 22, 2024
…r in-browser (streamlit#5945) With the incoming `@st.cache` deprecation, we're going to see a lot of apps with a lot of deprecation warnings. Currently, we show deprecation warnings in the browser, which is convenient for an app's developer - but sucks for app viewers. With this PR, we will now only print deprecation warnings to the browser when `"client.showErrorDetails"=True`. This config option is currently used to suppress app exception tracebacks from being printed to the browser, so this is a slight overloading of its original purpose - but it feels appropriate (the circumstance where you don't want to loudly display exception tracebacks - when you have a deployed app - is exactly the same as when you don't want to display deprecation warnings). Deprecation warnings now also always get logged to the console, so developers will see them in their logs regardless of whether they're displayed in-browser.
zyxue
pushed a commit
to zyxue/streamlit
that referenced
this pull request
Apr 16, 2024
…r in-browser (streamlit#5945) With the incoming `@st.cache` deprecation, we're going to see a lot of apps with a lot of deprecation warnings. Currently, we show deprecation warnings in the browser, which is convenient for an app's developer - but sucks for app viewers. With this PR, we will now only print deprecation warnings to the browser when `"client.showErrorDetails"=True`. This config option is currently used to suppress app exception tracebacks from being printed to the browser, so this is a slight overloading of its original purpose - but it feels appropriate (the circumstance where you don't want to loudly display exception tracebacks - when you have a deployed app - is exactly the same as when you don't want to display deprecation warnings). Deprecation warnings now also always get logged to the console, so developers will see them in their logs regardless of whether they're displayed in-browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the incoming
@st.cachedeprecation, we're going to see a lot of apps with a lot of deprecation warnings. Currently, we show deprecation warnings in the browser, which is convenient for an app's developer - but sucks for app viewers.With this PR, we will now only print deprecation warnings to the browser when
"client.showErrorDetails"=True. This config option is currently used to suppress app exception tracebacks from being printed to the browser, so this is a slight overloading of its original purpose - but it feels appropriate (the circumstance where you don't want to loudly display exception tracebacks - when you have a deployed app - is exactly the same as when you don't want to display deprecation warnings).Deprecation warnings now also always get logged to the console, so developers will see them in their logs regardless of whether they're displayed in-browser.