[optimization] Do not re-fetch resource on first attempt on upgrade #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msafwankarim
approved these changes
Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the #877 change we noticed a performance degradation with Reloader on one of our clusters, having quite a lot of traffic with constant changes to CMs and Secrets. With the current implementation we are getting into API Server rate limiting issues.
When
upgradestarts all the resources per kind are fetched with theItemsFuncand right after that for each of the items it is again re-fetched with theItemFunc. This is suboptimal and brings quite a lot more unnecessary API calls. We should re-fetch resource only when there is a conflict error. This approach is implemented with this change.