Support for resource patching with retries #877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ref #766. |
|
Hi! We looked through this and are satisfied so far, nice job! You can ping me here or in slack and I'll make sure to run them as soon as i see it. :) |
* Initial * State * State * Revert unintentional change * Update * Update * Fix tests * Support patching for both reload strategies * rolling_upgrade tests * Update * More tests * Remove unnecessary stuff
|
@Felix-Stakater thank you for looking into it. I did rebase to current master, and fixed lint issues. |
Felix-Stakater
approved these changes
May 12, 2025
|
Thank you! :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For our scenario we need to scale Reloader to multiple Pods and the current HA implementation causes problems while we need zero downtime and leader election can not provide that with the current implementation.
Solution for us to increase resilience is to include
patchon resources which will reduce conflicts possibility when multiple clients are trying. Also it solves the case for multiple restarts due to patching based on CM or Secret hash value, which will be same for all clients patch requests and one restart should be triggered.For non-patch possible workloads, we introduce retries on conflicts, which will help to avoid missed updates.
PR introduces:
retry.RetryOnConflictinPerformActionfor the upgrade handlerWe would appreciate your comments and review. Thanks in advance.