Disable Devel and PR jobs for rcl. #478
Conversation
|
The commit contains many unrelated items. |
yes. Fixing. |
The group dependency on a logger package prevents builds from running.
61ead08 to
518b543
Compare
| @@ -813,7 +813,7 @@ repositories: | |||
| url: https://github.com/ros2-gbp/rcl-release.git | |||
| version: 0.6.2-0 | |||
| source: | |||
| test_pull_requests: true | |||
| test_commits: false | |||
There was a problem hiding this comment.
http://www.ros.org/reps/rep-0143.html has both test_pull_requests and test_commits. What's the difference?
test_commits: a boolean flag used to enable CI jobs for each commit to the branch specified under versions. (default: false)
test_pull_requests: a boolean flag used to enable CI jobs for each pull request against the branch specified under version. (default: false)
There was a problem hiding this comment.
One tests each commit to the source branch, the other tests each pull request targeting the source branch.
There was a problem hiding this comment.
My information is based on observation rather than specification
test_commits runs a job whenever a new commit is made to a specific branch. The jobs on http://build.ros2.org/view/Cdev/ test commits to the source branch.
test_pull_requests runs a new job whenever a PR is opened against a branch. The jobs on http://build.ros2.org/view/Cpr/ test pull requests on that branch.
The defaults for crystal are here https://github.com/ros2/ros_buildfarm_config/blob/3755c1ea027e65f026b8056fc159552393bdc333/crystal/source-build.yaml#L88-L91
The group dependency on a logger package prevents builds from running.
The group dependency on a logger package prevents builds from running.
The group dependency on a logger package prevents builds from running.