Skip to content

Add rcpputils to ros2.repos #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

Add rcpputils to ros2.repos #661

merged 1 commit into from
Mar 20, 2019

Conversation

emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Feb 26, 2019 •
edited by mjcarroll
Loading

Related to #664

┆Issue is synchronized with this Asana task

@tfoote tfoote added the in review Waiting for review (Kanban column) label Feb 26, 2019
thomas-moulard
thomas-moulard approved these changes Feb 26, 2019
View reviewed changes
Copy link

@thomas-moulard thomas-moulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

thomas-moulard
thomas-moulard reviewed Feb 26, 2019
View reviewed changes
Add rcpputils to ros2.repos
f61052f 
Signed-off-by: Emerson Knapp <eknapp@amazon.com>
@wjwwood
Copy link
Member

wjwwood commented Feb 26, 2019

This repository's packages should build before we merge this.

Starting >>> rcpputils
--- output: rcpputils
CMake Error: The source directory "/Users/william/ros2_ws/src/ros2/rcpputils" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
---
--- stderr: rcpputils
CMake Error: The source directory "/Users/william/ros2_ws/src/ros2/rcpputils" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
---
Failed   <<< rcpputils	[ Exited with code 1 ]

@emersonknapp
Copy link
Contributor Author

@wjwwood Agreed - once we merge this one then it will build ros2/rcpputils#2

@emersonknapp emersonknapp mentioned this pull request Feb 27, 2019
Closed
3 tasks
@emersonknapp emersonknapp mentioned this pull request Mar 8, 2019
Merged
@emersonknapp
Copy link
Contributor Author

@thomas-moulard can you trigger CI for this? https://raw.githubusercontent.com/ros2/ros2/f61052f28acfc36bcebe201bcf43ed246e3bcf4e/ros2.repos

@nuclearsandwich
Copy link
Member

CI build up to rcpputils, test only rcpputils. Let me know if there's anything else we should test on top of this.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@emersonknapp
Copy link
Contributor Author

@nuclearsandwich no other packages are including it yet, so that build/test is all we need

@emersonknapp
Copy link
Contributor Author

@tfoote Thanks for approving, should we merge?

@tfoote tfoote merged commit 0351658 into ros2:master Mar 20, 2019
@tfoote tfoote removed the in review Waiting for review (Kanban column) label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

+1 more reviewer

@thomas-moulard thomas-moulard thomas-moulard approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emersonknapp @wjwwood @nuclearsandwich @thomas-moulard @tfoote