Skip to content

[ROS2 QA] Implement PoC for Thread-Safety annotation #664

@thomas-moulard

Description

@thomas-moulard

Implement PoC for Thread-Safety annotation

Clang doc here: https://clang.llvm.org/docs/ThreadSafetyAnalysis.html

Candidate class for the PoC is https://github.com/ros2/rmw_fastrtps/blob/705a0c07ca9f3708028660c41de6eadfad16e9f5/rmw_fastrtps_shared_cpp/include/rmw_fastrtps_shared_cpp/topic_cache.hpp

Owner: @emersonknapp / @ros2/aws-robotics

Exit Criteria

  • Add Thread-Safety annotations macro to e.g. rcutils (see mutex.h in https://clang.llvm.org/docs/ThreadSafetyAnalysis.html) - which repo should be cleared with OSRF first
  • Modify rmw_fastrtps* packages to build with -Wthread-safety by default when Clang is chosen.
  • Modify topic_cache.hpp to use thread-safety annotations.

Progress Tracking

Connects to #662

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions