fix(binop/in): don't optimize external references away #6042
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## fix/6040 #6042 +/- ##
=========================================
Coverage 98.77% 98.77%
=========================================
Files 271 271
Lines 10597 10599 +2
Branches 2828 2829 +1
=========================================
+ Hits 10467 10469 +2
Misses 89 89
Partials 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Hi @cyyynthia, Thanks for your quick reactions! Could you merge your changes into PR #6041? That way, people can verify our fix all in one PR. |
|
It seems after changing the PR target branch, it can be merged into yours cleanly according to GitHub 😄 |
Merged
9 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2025
…xternal references away (#6041) * correct the logic of include in BinaryExpression * Improve coverage * fix(binop/in): don't optimize external references away (#6042) fixes #6035 (pt. 2) fixes withastro/astro#14152 * Ensure that includeNode is always called first similar to other nodes --------- Co-authored-by: Cynthia <cynthia@cynthia.dev> Co-authored-by: Lukas Taegert-Atkinson <lukas.taegert-atkinson@tngtech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like I broke quite a few things with my optimization thing q_q
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
fixes #6035 (pt. 2)
fixes withastro/astro#14152
Description
Makes sure the
'export' in nsoptimization is not applied to external references, including when the reference to an external module happens indirectly through reexports of a non-external module.