refactor: Clap attribute macros from #[clap(...)] to #[arg(...)] and #[command(...)] in v4.x #481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Wollac , I think the failing tests are not related to my PR. Is there anything I can do? |
All good, those tests are expected to fail for PRs from outside contributors, but we can still merge. |
Wollac
approved these changes
Mar 14, 2025
capossele
pushed a commit
that referenced
this pull request
Mar 17, 2025
…#[command(...)] in v4.x (#481) This PR updates deprecated `#[clap(...)]` attributes to their modern equivalents in `clap` 4.x. The current codebase still uses outdated syntax that has been deprecated since version 4.0. By making this update, we ensure compatibility with future versions and maintain code quality. Fixes #480 --------- Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
capossele
pushed a commit
that referenced
this pull request
Mar 17, 2025
…#[command(...)] in v4.x (#481) This PR updates deprecated `#[clap(...)]` attributes to their modern equivalents in `clap` 4.x. The current codebase still uses outdated syntax that has been deprecated since version 4.0. By making this update, we ensure compatibility with future versions and maintain code quality. Fixes #480 --------- Co-authored-by: Wolfgang Welz <welzwo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates deprecated
#[clap(...)]attributes to their modern equivalents inclap4.x.The current codebase still uses outdated syntax that has been deprecated since version 4.0.
By making this update, we ensure compatibility with future versions and maintain code quality.
Fixes #480