introduce -fail-level flag and deprecate -fail-on-error #1854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now reviewdog can control exit code based on issue severity. For example, if `-fail-level=warning`, then reviewdog will exit with 0 for issues with info severity, while it will exit with 1 if it finds issues with error, warning, or unknown severity. This change also fixes the feature parity with github-[pr-]check reporter. Previously, only this reporter didn't fail on warning or info level issues (#1846), and this behavior was removed during refactoring (#1846). Now users can use `-reporter=github-check -fail-level=error` to restore the previous behavior.
shogo82148
approved these changes
Jul 29, 2024
This was referenced Oct 8, 2024
This was referenced Dec 2, 2024
This was referenced Dec 2, 2024
Merged
This was referenced Feb 12, 2025
penelopeysm
added a commit
to TuringLang/actions
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now reviewdog can control exit code based on issue severity.
For example, if
-fail-level=warning, then reviewdog will exit with 0for issues with info severity, while it will exit with 1 if it finds issues with
error, warning, or unknown severity.
This change also fixes the feature parity with github-[pr-]check reporter.
Previously, only this reporter didn't fail on warning or info level issues (#1846),
and this behavior was removed during refactoring (#1846).
Now users can use
-reporter=github-check -fail-level=errorto restorethe previous behavior.