Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I found closers that aren't closed in doghouse. Since it's minor fix, feel free to ignore this.
Go Doc comment on
datastore.NewClient
says:// Call (*Client).Close() when done with the client.
Implementation of
(*Client).Close()
looks to close connection pooling.So it looks better to be closed.
Adding context, I'm not familiar doghouse at all (though I'm interested in reviewdog). Even I don't know how to run doghouse (#1194). I'm developing a static code analyzer and randomly scanning open projects to find practical false positives so that I can improve recall of the analyzer. I just found this problem by the analyzer and consider it's a true positive.