Determine docker host via env then context #2444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously always used the system default (eg /var/run/docker.sock) which would fail if the default docker socket was not installed, no longer symlinked to the home directory socket, or pointed to a daemon that wasn't running. This can happen when docker desktop and orbstack are running togehter on the same system. Now cog will try to find the daemon socket by looking at the following in order 1. the DOCKER_HOST env variable 2. the docker context specified by DOCKER_CONTEXT 3. the current docker context set in the docker config 4. the system default
8W9aG
approved these changes
Jul 3, 2025
michaeldwan
added a commit
that referenced
this pull request
Jul 21, 2025
* Determine docker host via env then context Previously always used the system default (eg /var/run/docker.sock) which would fail if the default docker socket was not installed, no longer symlinked to the home directory socket, or pointed to a daemon that wasn't running. This can happen when docker desktop and orbstack are running togehter on the same system. Now cog will try to find the daemon socket by looking at the following in order 1. the DOCKER_HOST env variable 2. the docker context specified by DOCKER_CONTEXT 3. the current docker context set in the docker config 4. the system default * remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2436
Previously always used the system default (eg
/var/run/docker.sock) ifDOCKER_HOSTwasn't set. This could fail if the default docker socket was not installed, no longer symlinked to the home directory socket, or pointed to a daemon that wasn't running, which could happen if docker desktop and orbstack are running together on the same system.Now cog will try to find the daemon socket by looking at the following in order
DOCKER_HOSTenv variableDOCKER_CONTEXT