Skip to content

Docker client fixes #2419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 20, 2025
Merged

Docker client fixes #2419

merged 16 commits into from
Jun 20, 2025

Conversation

michaeldwan
Copy link
Member

@michaeldwan michaeldwan commented Jun 19, 2025

This PR contains a few fixes to the docker client and surrounding code. While testing #2417 I realized tox was blocking the COG_DOCKER_SDK_CLIENT variable in some integration tests, but it was correct on others. I sorted that out so the entire suite is ran against both clients and fixed up some issues that came up.

The actual changes are pretty small, but the diff is huge because I added pexpect to the test group for a new integration test.

Here's what's fixed:

  • add a timeout to the predictor health check loop so a hanging model won't block startup
  • set the buildkit frontend syntax to the latest dockerfile version
  • bind exposed ports to ipv6 in addition to ipv4
  • only attach stdin to the container if stdin has data to read (like a file or pipe)
  • fix relative path to project root for docker context when running in a sub directory
  • fix for additional contexts being available but missing a name for the docker frontend
  • smarter handling of interactive/tty handling for stdin (and integration tests!)

@michaeldwan michaeldwan marked this pull request as draft June 19, 2025 16:12
@michaeldwan michaeldwan marked this pull request as ready for review June 19, 2025 22:09
@michaeldwan michaeldwan requested a review from a team June 20, 2025 15:39
@michaeldwan michaeldwan enabled auto-merge (squash) June 20, 2025 17:05
@michaeldwan michaeldwan merged commit 7022b15 into main Jun 20, 2025
48 of 49 checks passed
@michaeldwan michaeldwan deleted the md/docker-client-fixes branch June 20, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants