Enable docker api client by default #2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR switches the default Docker client from the CLI to the new API client, streamlining the experience by enabling it by default unless overridden.
- Switches client selection logic to use util.GetEnvOrDefault with a default true value
- Removes the direct dependency on the os package for environment variable lookup
Comments suppressed due to low confidence (1)
pkg/docker/docker.go:13
- Consider adding unit tests to verify that the client selection logic based on the 'COG_DOCKER_SDK_CLIENT' environment variable behaves as expected when not explicitly set and when set to false.
if !util.GetEnvOrDefault("COG_DOCKER_SDK_CLIENT", true, strconv.ParseBool) {
74df2d8 to
55fb019
Compare
Merged
fallback to cli with COG_DOCKER_SDK_CLIENT=0
9756c54 to
9ae4493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the default docker client to the new one introduced in #2327. It's been available for about a month by calling with
COG_DOCKER_SDK_CLIENT=1.No show-stopping issues came up through internal testing or integration tests on CI, but if anything does arise users can revert to the previous behavior by running with
COG_DOCKER_SDK_CLIENT=0, such as: