Skip to content

Check version formats in fast_generator #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

Check version formats in fast_generator #2129

merged 1 commit into from
Jan 28, 2025

Conversation

nevillelyh
Copy link
Contributor

@nevillelyh nevillelyh commented Jan 28, 2025 •
edited
Loading

Incorrect formats will likely fail monobase.build but it's nice to fail fast here.

We now:

@nevillelyh nevillelyh requested a review from 8W9aG January 28, 2025 00:18
@nevillelyh nevillelyh force-pushed the neville/fast-versions branch from a3c7d8e to a8c5b6d Compare January 28, 2025 00:36
@nevillelyh nevillelyh force-pushed the neville/fast-versions branch from a8c5b6d to 2c9af66 Compare January 28, 2025 19:36
@nevillelyh nevillelyh force-pushed the neville/fast-versions branch from 2c9af66 to 1214cec Compare January 28, 2025 19:46
@nevillelyh nevillelyh merged commit 9fe30d7 into main Jan 28, 2025
21 checks passed
@nevillelyh nevillelyh deleted the neville/fast-versions branch January 28, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8W9aG 8W9aG 8W9aG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nevillelyh @8W9aG