Skip to content

Conversation

fd0
Copy link
Member

@fd0 fd0 commented Jul 17, 2017

Closes #1093

@tmcarr
Copy link
Contributor

tmcarr commented Jul 17, 2017

What vendoring tool is restic using? Is there a timeline on getting it ported to dep?

@fd0
Copy link
Member Author

fd0 commented Jul 17, 2017

restic uses gb and gb vendor. Due to the different project layout used with gb, it may not so easy to switch to dep. I haven't had a look yet, is dep already done/stable?

@tmcarr
Copy link
Contributor

tmcarr commented Jul 17, 2017

It was announced at gophercon the other day that it is production ready and stable.

Merging it into the core toolchain has yet to happen though.

@fd0
Copy link
Member Author

fd0 commented Jul 17, 2017

Ah, thanks for the info. I haven't seen that announcement yet.

@codecov-io
Copy link

codecov-io commented Jul 17, 2017

Codecov Report

Merging #1108 into master will increase coverage by <.01%.
The diff coverage is 12.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1108      +/-   ##
=========================================
+ Coverage   52.89%   52.9%   +<.01%     
=========================================
  Files         118     118              
  Lines       11318   11299      -19     
=========================================
- Hits         5987    5978       -9     
+ Misses       4616    4610       -6     
+ Partials      715     711       -4
Impacted Files Coverage Δ
src/restic/backend/s3/s3.go 59.65% <12.5%> (+0.1%) ⬆️
src/restic/archiver/archiver.go 64.73% <0%> (-0.17%) ⬇️
src/restic/backend/sftp/sftp.go 60.82% <0%> (+0.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45abac...89ace85. Read the comment docs.

@fd0 fd0 changed the title Update vendored deps (except minio-go) Update vendored deps Jul 17, 2017
@fd0 fd0 merged commit 89ace85 into master Jul 17, 2017
fd0 added a commit that referenced this pull request Jul 17, 2017
@fd0 fd0 deleted the update-deps branch July 17, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants