Skip to content

WIP Create spring boot starter with spring factory #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2019

Conversation

kakawait
Copy link
Contributor

No description provided.

@kakawait kakawait changed the title Create spring boot starter with spring factory WIP Create spring boot starter with spring factory Jun 26, 2019
@remkop remkop added this to the 4.0 milestone Jun 26, 2019
@remkop remkop merged commit 8569785 into remkop:master Jul 6, 2019
@remkop
Copy link
Owner

remkop commented Jul 6, 2019

Finally ready to start working on this.
Thanks a lot for the pull request!

remkop added a commit that referenced this pull request Jul 6, 2019
remkop added a commit that referenced this pull request Jul 7, 2019
remkop added a commit that referenced this pull request Jul 7, 2019
remkop added a commit that referenced this pull request Jul 8, 2019
remkop added a commit that referenced this pull request Jul 10, 2019
remkop added a commit that referenced this pull request Jul 10, 2019
…cli-spring-boot-starter

For now I prefer the simplicity of having a single module.
The [docs](https://docs.spring.io/spring-boot/docs/current/reference/html/boot-features-developing-auto-configuration.html#boot-features-custom-starter-naming) mention that if you only have one module that combines [the starter and auto-configuration], name it XXX-spring-boot-starter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: module An issue or change related to JPMS modules type: API 🔌 type: enhancement ✨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants