Dropping symbol-observable dependency, realizing internal implementation #3631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-docs ready! Built with commit 9ccd7ef |
|
I'm not seeing a package-lock.json update. Can you include that? |
|
Are you using a recent version of npm? I would bump up to the latest (6.13, I think?), as the package-lock.json should have sha512 hashes in it. |
|
051aae9 to
9ccd7ef
Compare
|
I fixed it up for you now. Thanks for the PR! |
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…ion (reduxjs#3631) * Dropped symbol-observable dep, implemented internal polyfill * Fixing prettier issues * Removed obsolete reference from types * Fix more prettier issues * Add package-lock.json Former-commit-id: 1c32d22 Former-commit-id: 216f2be
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…ion (reduxjs#3631) * Dropped symbol-observable dep, implemented internal polyfill * Fixing prettier issues * Removed obsolete reference from types * Fix more prettier issues * Add package-lock.json Former-commit-id: 1c32d22 Former-commit-id: 216f2be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partialy fixes #3567
Removed
symbol-observablefrompackage.jsonand added a polifyll to/src/utils/symbol-observable, similar to RxJs implementation.Sorry for the mess, I do not know what is wrong with my pc and why it keeps messing up the formatting.