Fix isNodeInDocument for HTML5Backend when used in iframes #3271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The isNodeInDocument function is used to check if a node was detached during a drag event. It checks to make sure this `this.document.body` is defined, but then checks if `document.body` contains the given node. When used within an iframe, `document` in the global context may not be the same as `this.document`. This commit updates the check to use `this.document.body`.
|
Hey @darthtrevino , any chance I can get a review on this? |
|
Looks great, I'll merge on Sunday when I'm back from backpacking |
darthtrevino
approved these changes
Aug 6, 2021
|
@darthtrevino sorry for another ping, but could we cut a new release to get this code up for public use? |
darthtrevino
pushed a commit
that referenced
this pull request
Feb 3, 2022
The isNodeInDocument function is used to check if a node was detached during a drag event. It checks to make sure this `this.document.body` is defined, but then checks if `document.body` contains the given node. When used within an iframe, `document` in the global context may not be the same as `this.document`. This commit updates the check to use `this.document.body`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isNodeInDocument function is used to check if a node was detached during a drag event. It checks to make sure
this.document.bodyis defined, but then checks ifdocument.bodycontains the given node.When this library is used within an iframe,
documentin the global context may not be the same asthis.document. This commit updates the check to usethis.document.body, which should correctly check against the current context instead of the global document.