Improve exception messages for invalid callables #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,51 @@ public function __construct(array $inProgressMakes, $message = "", $code = 0, \E | |||
| } | |||
|
|
|||
| /** | |||
| * Add a human readable version of the invalid callable to the standard 'invalid invokable' message. | |||
| * @param array $inProgressMakes | |||
| * @param $callableOrMethodStr | |||
There was a problem hiding this comment.
It's actually not string|callable....It also includes ['classname', 'methodName'] and Auryn interprets this as "create an instance of that class and then call the method on it. That does not fit into string|callable.
There was a problem hiding this comment.
string|array|callable then?
There was a problem hiding this comment.
@kelunik Do you really think that a docblock thing like that would actually add any value?
Regardless, I've updated the code to be consistent with how the rest of the library documents params.
There was a problem hiding this comment.
Probably not, as many values are accepted, but int for example is not.
rdlowrey
added a commit
that referenced
this pull request
Dec 9, 2015
Improve exception messages for invalid callables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I keep herp-derping while writing code, with typos in function names. This PR adds a human readable string of the callable in the cases where the 'invalid invokable' exception occurs.
It also fixes an issue where a bare ReflectionException escapes from the library without having been caught and turned into an Auryn specific exception.