Only allow Discord sign-ups #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67% of users have a Discord account linked but not CAS. If they accidentally sign up with CAS then a duplicate is created with no way of us realizing it unless the user tries to connect Discord. If we only allow Discord sign-up, users cannot accidentally create duplicate accounts and we can direct everyone to signup/login with Discord and then immediately connect with CAS, filling in the blanks. Once we have done that, we can reenable the other signup methods.
|
My concern would be those who do not have RPI accounts such as external
mentors and alumni. How will this be handled?
Prof. Turner
…On Wed, Dec 29, 2021 at 12:03 AM Frank Matranga ***@***.***> wrote:
67% of users have a Discord account linked but not CAS. If they
accidentally sign up with CAS then a duplicate is created with no way of us
realizing it unless the user tries to connect Discord.
If we only allow Discord sign-up, users cannot accidentally create
duplicate accounts and we can direct everyone to signup/login with Discord
and then immediately connect with CAS, filling in the blanks. Once we have
done that, we can reenable the other signup methods.
------------------------------
You can view, comment on, or merge this pull request online at:
#217
Commit Summary
- 5f65828
<5f65828>
Only allow Discord sign-ups
File Changes
(1 file <https://github.com/rcos/Telescope/pull/217/files>)
- *M* src/templates/auth.rs
<https://github.com/rcos/Telescope/pull/217/files#diff-349f5749d6c18965b380772ecc1d86d4b3abd6123c45a83504a3f29ac3eb2751>
(24)
Patch Links:
- https://github.com/rcos/Telescope/pull/217.patch
- https://github.com/rcos/Telescope/pull/217.diff
—
Reply to this email directly, view it on GitHub
<#217>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUG724MX7MZHREA2BWL66LUTKJC5ANCNFSM5K5I42EQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
--
* Wesley D. Turner, Ph.D. * Director of the Rensselaer Center for Open
Source and Senior Lecturer | Department of Computer Science | Rensselaer
Polytechnic Institute | 110 8th Street | Troy, New York 12180-3590 |
***@***.*** | (518)276-8184
|
I don't believe this would affect them as they could use Discord to sign-up and log-in. |
|
Tentatively this looks good but I want to test it a bit tomorrow just in case. We will leave the endpoints available but without any way to navigate with them we don't have to worry about people finding them I think. |
vcfxb
approved these changes
Dec 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
67% of users have a Discord account linked but not CAS. If they accidentally sign up with CAS then a duplicate is created with no way of us realizing it unless the user tries to connect Discord.
If we only allow Discord sign-up, users cannot accidentally create duplicate accounts and we can direct everyone to signup/login with Discord and then immediately connect with CAS, filling in the blanks. Once we have done that, we can reenable the other signup methods.