Add observability for label-selectors #53423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Guo <aguo@anyscale.com>
|
@nikitavemuri @MengjinYan, this is working except for the export task events. Any ideas what's missing? @MengjinYan , ptal if this interferes with your new export work. |
|
Any idea why clang-format is not working? I installed it on my mac with |
I tried with a local setup and I can see the Is it something you tested or you were looking at something else for the export task event?
No. This won't interferes with my work now. |
I never tried Normally I follow https://docs.ray.io/en/latest/ray-contribute/development.html#installing-additional-dependencies-for-development to install the additional dependencies for lint: Probably you can try that to see if it will be helpful. |
yes, this fixed it. Thanks! |
ryanaoleary
approved these changes
Jun 5, 2025
MengjinYan
approved these changes
Jun 11, 2025
elliot-barn
pushed a commit
that referenced
this pull request
Jun 18, 2025
label-based selection is being added as a feature. tracker here: #51564 As part of the feature, we should allow users to observe labels of nodes and selection rules of tasks and actors. This PR adds these fields to: - state api CLI output - state api API responses - Ray Dashboard UI Nodes:   Tasks:   Actors:   --------- Signed-off-by: Alan Guo <aguo@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
23 tasks
elliot-barn
pushed a commit
that referenced
this pull request
Jul 2, 2025
label-based selection is being added as a feature. tracker here: #51564 As part of the feature, we should allow users to observe labels of nodes and selection rules of tasks and actors. This PR adds these fields to: - state api CLI output - state api API responses - Ray Dashboard UI Nodes:   Tasks:   Actors:   --------- Signed-off-by: Alan Guo <aguo@anyscale.com> Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Merged
8 tasks
edoakes
pushed a commit
that referenced
this pull request
Jul 9, 2025
…and task detail pages (#54292) Follow-up to #53423 Missed a few places in the UI. Also updates placement group tables to use the same code preview component as the actor and tasks tables. Placement group table   Actor detail  Task detail  --------- Signed-off-by: Alan Guo <aguo@anyscale.com>
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
…and task detail pages (ray-project#54292) Follow-up to ray-project#53423 Missed a few places in the UI. Also updates placement group tables to use the same code preview component as the actor and tasks tables. Placement group table   Actor detail  Task detail  --------- Signed-off-by: Alan Guo <aguo@anyscale.com> Signed-off-by: ChanChan Mao <chanchanmao1130@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
label-based selection is being added as a feature. tracker here: #51564
As part of the feature, we should allow users to observe labels of nodes and selection rules of tasks and actors.
This PR adds these fields to:
Nodes:
Tasks:
Actors:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.