Skip to content

[Doc] Added ray-serve llm doc #52832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 12, 2025
Merged

Conversation

Blaze-DSP
Copy link
Contributor

@Blaze-DSP Blaze-DSP commented May 7, 2025

Why are these changes needed?

Add example of serving a Large Language Model using Ray Serve LLM on Kubernetes

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@Blaze-DSP Blaze-DSP requested review from pcmoritz, kevin85421 and a team as code owners May 7, 2025 05:29
@hainesmichaelc hainesmichaelc added the community-contribution Contributed by the community label May 7, 2025
@kevin85421
Copy link
Member

Can you fix the CI error? In addition, each commit needs to commit with git commit .... -s to avoid "DCO" failing.

@Blaze-DSP Blaze-DSP force-pushed the ray-serve/llm branch 2 times, most recently from 1ff1edc to b49a3e0 Compare May 8, 2025 17:19
Copy link
Contributor

@pcmoritz pcmoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for contributing this, it looks good to me. Before merging this, we first need to merge ray-project/kuberay#3517 :)

@kevin85421 Can you drive that PR forward?

DPatel_7 added 6 commits May 12, 2025 20:26
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
fix
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
@Blaze-DSP
Copy link
Contributor Author

made updates. @kevin85421

fix
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
@masoudcharkhabi masoudcharkhabi added serve Ray Serve Related Issue docs An issue or change related to documentation labels May 12, 2025
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind verifying whether the YAML (ray-project/kuberay#3517 (review)) still works or not? This doc has removed the step of creating a namespace, but the YAML still uses the namespace.

Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
DPatel_7 added 2 commits May 28, 2025 12:38
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
@eicherseiji eicherseiji self-assigned this Jun 5, 2025
Copy link
Contributor

@eicherseiji eicherseiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a closer look this afternoon; might push some edits

Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
@eicherseiji
Copy link
Contributor

@kevin85421 Ready to merge when green

@eicherseiji eicherseiji added the go add ONLY when ready to merge, run all tests label Jun 9, 2025
eicherseiji and others added 5 commits June 10, 2025 12:54
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: Seiji Eicher <58963096+eicherseiji@users.noreply.github.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

For additional security, instead of passing the HF Access Token directly as an environment variable, create a Kubernetes Secret containing your Hugging Face access token. Download the Ray Serve LLM service config .yaml file using the following command:

```sh
curl -o ray-service.llm-serve.yaml https://raw.githubusercontent.com/ray-project/kuberay/master/ray-operator/config/samples/ray-service.llm-serve.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@angelinalg angelinalg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some style nits. I'd appreciate you fixing prior to merge to decrease tech debt. Thanks!

eicherseiji and others added 2 commits June 12, 2025 13:00
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Signed-off-by: Seiji Eicher <58963096+eicherseiji@users.noreply.github.com>
@kevin85421
Copy link
Member

cc @jjyao @edoakes would you mind merging this PR? Thanks!

@jjyao jjyao changed the title added ray-serve llm doc [Doc] added ray-serve llm doc Jun 12, 2025
@jjyao jjyao changed the title [Doc] added ray-serve llm doc [Doc] Added ray-serve llm doc Jun 12, 2025
@jjyao jjyao merged commit d3c025c into ray-project:master Jun 12, 2025
5 checks passed
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
Add example of serving a Large Language Model using Ray Serve LLM on Kubernetes

Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <58963096+eicherseiji@users.noreply.github.com>
Co-authored-by: DPatel_7 <dpatel@gocommotion.com>
Co-authored-by: Seiji Eicher <seiji@anyscale.com>
Co-authored-by: Seiji Eicher <58963096+eicherseiji@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
Add example of serving a Large Language Model using Ray Serve LLM on Kubernetes

Signed-off-by: DPatel_7 <dpatel@gocommotion.com>
Signed-off-by: Seiji Eicher <seiji@anyscale.com>
Signed-off-by: Seiji Eicher <58963096+eicherseiji@users.noreply.github.com>
Co-authored-by: DPatel_7 <dpatel@gocommotion.com>
Co-authored-by: Seiji Eicher <seiji@anyscale.com>
Co-authored-by: Seiji Eicher <58963096+eicherseiji@users.noreply.github.com>
Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com>
Co-authored-by: Kai-Hsun Chen <kaihsun@apache.org>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Contributed by the community docs An issue or change related to documentation go add ONLY when ready to merge, run all tests llm serve Ray Serve Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants