[core][autoscaler] Don't error if rayStartParams absent #51954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are planning on making `rayStartParams` optional and not present in the RayCluster K8s custom resource output if it's empty. ray-project/kuberay#3202 We need to make its autoscaler code not error when it's absent. This change is also needed for the integration tests in that PR to pass. Signed-off-by: David Xia <david@davidxia.com>
|
cc @rueian would you mind reviewing this PR? Thanks! |
kevin85421
approved these changes
Apr 3, 2025
|
@davidxia please ping me when all CI pass! Thanks! |
davidxia
added a commit
to davidxia/kuberay
that referenced
this pull request
May 9, 2025
in `ray-operator/test/e2erayservice/rayservice_ha_test.go`'s `TestRayServiceZeroDowntimeUpgrade` and `TestAutoscalingRayService`. They currently fail because the autoscaler is using Ray 2.41.0 and doesn't have this patch. ray-project/ray#51954 We will revert this commit after Ray is upgraded in this repo to 2.45.0 or above in PRs like ray-project#3547. Signed-off-by: David Xia <david@davidxia.com>
davidxia
added a commit
to davidxia/kuberay
that referenced
this pull request
May 10, 2025
* `RayClusters` with `rayStartParams: {}` will continue to be serialized with
the empty map.
* `RayClusters` without `rayStartParams` will be serialized without the field.
This prevents a backwards-incompatible change with RayClusters that use the
autoscaler with Ray versions earlier than 2.45.0 which lack this change
ray-project/ray#51954.
Signed-off-by: David Xia <david@davidxia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are planning on making
rayStartParamsoptionaland not present in the RayCluster K8s custom resource output
if it's empty. ray-project/kuberay#3202
We need to make its autoscaler code not error when it's absent.
This change is also needed for the integration tests in that PR to pass.
Signed-off-by: David Xia david@davidxia.com
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.