[Core] Ignore stale ReportWorkerBacklogRequest #50280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
sutibu
reviewed
Feb 6, 2025
src/ray/raylet/node_manager.cc
Outdated
| send_reply_callback(Status::OK(), nullptr, nullptr); | ||
| return; | ||
| } | ||
|
|
||
| local_task_manager_->ClearWorkerBacklog(worker_id); |
There was a problem hiding this comment.
if worker_id is not in the worker_pool, should one ClearWorkerBacklog(worker_id) anyway to set backlog to empty?
There was a problem hiding this comment.
That has already been called when the worker is marked dead.
jjyao
commented
Feb 10, 2025
Comment on lines
+1863
to
+1868
| if (worker_pool.GetRegisteredWorker(worker_id) == nullptr && | ||
| worker_pool.GetRegisteredDriver(worker_id) == nullptr) { | ||
| // The worker is already disconnected. | ||
| send_reply_callback(Status::OK(), nullptr, nullptr); | ||
| return; | ||
| } |
There was a problem hiding this comment.
This is the actual fix. The remaining of this PR is to make it unit testable.
MengjinYan
reviewed
Feb 11, 2025
MengjinYan
approved these changes
Feb 11, 2025
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
xsuler
pushed a commit
to antgroup/ant-ray
that referenced
this pull request
Mar 4, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
park12sj
pushed a commit
to park12sj/ray
that referenced
this pull request
Mar 18, 2025
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
For
ReportWorkerBacklogRequestthat's received after the core worker is marked as dead, we should ignore. Otherwise, we will have permanently leaked backlogs.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.