[core] fix test_unpickleable_stacktrace test on windows #55523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 11, 2025 05:39
…tions to improve debugability Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
Signed-off-by: sampan <sampan@anyscale.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable improvement for debugging by enhancing the error message for unpickleable exceptions. When deserialization fails, the error now includes the string representation and stack trace of the original exception, which is very helpful. The changes also include a fix for a test case on Windows by scrubbing Cython-related frames from tracebacks, ensuring test consistency across platforms. The tests have been updated accordingly to reflect these changes, and a minor refactoring improves test readability. The changes are well-implemented and address the stated problem effectively. I have no further comments and approve of these changes.
edoakes
approved these changes
Aug 12, 2025
|
nice, ty for running windows tests 👍 |
8 tasks
dioptre
pushed a commit
to sourcetable/ray
that referenced
this pull request
Aug 20, 2025
…55523) fix `test_traceback::test_unpickleable_stacktrace()` test case on windows by scrubbing logs related to `ray._raylet` before assertion ci run with failure: https://buildkite.com/ray-project/postmerge/builds/12165#01989bf5-4008-4098-a6ff-1963047047a6/3056-3537 --------- Signed-off-by: sampan <sampan@anyscale.com> Co-authored-by: sampan <sampan@anyscale.com> Signed-off-by: Andrew Grosser <dioptre@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
fix
test_traceback::test_unpickleable_stacktrace()test case on windows by scrubbing logs related toray._rayletbefore assertionci run with failure: https://buildkite.com/ray-project/postmerge/builds/12165#01989bf5-4008-4098-a6ff-1963047047a6/3056-3537
Related issue number
NA
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.