Skip to content

Make Ray releases tests use pydantic>=2.5.0 #41244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Nov 21, 2023
Merged

Make Ray releases tests use pydantic>=2.5.0 #41244

merged 27 commits into from
Nov 21, 2023

Conversation

can-anyscale
Copy link
Contributor

@can-anyscale can-anyscale commented Nov 17, 2023 •
edited by shrekris-anyscale
Loading

Why are these changes needed?

As a follow-up to #40451, this change makes all the Ray release tests use pydantic>=2.5.0.

Additional changes:

  • The linter now uses mypy==1.7.0.
  • All Ray release tests, including workspace templates, now use deepspeed>=0.12.3.
  • This change fix the serve_resnet_benchmark.py release test, which is broken on master.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Release tests
      • This change updates Ray release tests.

@can-anyscale can-anyscale requested a review from a team as a code owner November 17, 2023 22:10
@can-anyscale
byod change
b722b46 
Signed-off-by: can <can@anyscale.com>
aslonnie
aslonnie reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@aslonnie aslonnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ready for review? could you say more in the PR title and description for the context?

@can-anyscale
Copy link
Contributor Author

w00t did I add you as a reviewer; this is for @shrekris-anyscale , he will pick this up

@shrekris-anyscale
Merge branch 'master' of github.com:ray-project/ray into can-byod
055fb53
@shrekris-anyscale
Organize dependencies
b9576c6 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Update 3.9 ML dependencies
f6015c5 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Update pydantic versions in pip freeze
38c8a56 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Update requirements_buildkite.in
8f4d867 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Update mypy version in format.sh
ed4df49 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Remove pydantic pin
5e879ec 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Update more pydantic pins
a5a4afc 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Update deepspeed pins
db788c1 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale shrekris-anyscale changed the title byod change Make Ray releases test use pydantic>=2.5.0 Nov 18, 2023
@shrekris-anyscale shrekris-anyscale changed the title Make Ray releases test use pydantic>=2.5.0 Make Ray releases tests use pydantic>=2.5.0 Nov 18, 2023
@shrekris-anyscale
Remove anyscale from BUILD file
8a765ed 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Remove changes to release/requirements_buildkite.in
dd053f9 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Remove changes to release/requirements_buildkite.txt
c4aedf1 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Remove changes to release/requirements.txt
1ab8313 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Remove changes to release/BUILD
9dced03 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Merge branch 'master' of github.com:ray-project/ray into can-byod
abb4053
@shrekris-anyscale
Add missing await
403ef22 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale
Add back removed test
56f8629 
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
@shrekris-anyscale shrekris-anyscale requested review from kouroshHakha and removed request for shrekris-anyscale November 19, 2023 20:15
@shrekris-anyscale
Copy link
Contributor

serve_resnet_benchmark passed with the change. Buildkite link

@shrekris-anyscale
Copy link
Contributor

The only remaining stable/non-flaky/non-jailed test that failed is long_running_serve.aws (Buildkite link). This also failed on master last night due to an infra error (link). I don’t think this test uses pydantic in any unique way, and the error traceback was the same on master and on the PR, so I think the PR run also failed due to an infra error.

@shrekris-anyscale
Copy link
Contributor

shrekris-anyscale commented Nov 20, 2023 •
edited
Loading

Here's a link to the Buildkite run where the rest of the stable/non-flaky/non-jailed tests pass.

Note that this run happened before I made the serve_resnet_benchmark fix, so the serve_resnet_benchmark failure is no longer relevant.

@shrekris-anyscale shrekris-anyscale added the release-blocker P0 Issue that blocks the release label Nov 20, 2023
ericl
ericl approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@ericl ericl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stamping for codeowners

@shrekris-anyscale
Copy link
Contributor

shrekris-anyscale commented Nov 20, 2023 •
edited
Loading

I kicked off a long_running_serve.aws run on the commit just before the pydantic version was updated: Buildkite link.

Screen Shot 2023-11-20 at 11 00 06 AM

kouroshHakha
kouroshHakha approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the failures on RLlib. They are not related. Separately pinged @sven1977 on what needs to be done there.

c21
c21 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The jailed test failure on Data side should be irrelevant (out of disk error). Okay to merge.

@shrekris-anyscale
Copy link
Contributor

The long_running_serve.aws smoke test ran successfully: Buildkite link

@shrekris-anyscale
Copy link
Contributor

shrekris-anyscale commented Nov 21, 2023 •
edited
Loading

I kicked off a long_running_serve.aws run on #41237 just before the pydantic version was updated: Buildkite link.

The run failed with the same error as this PR. It's unlikely that this PR is the root cause. There are no remaining test failures connected to this PR.

@architkulkarni This PR is ready to merge.

@architkulkarni architkulkarni merged commit a3e5c7e into master Nov 21, 2023
@architkulkarni architkulkarni deleted the can-byod branch November 21, 2023 19:32
@shrekris-anyscale shrekris-anyscale mentioned this pull request Nov 21, 2023
Closed
@edoakes
Copy link
Collaborator

edoakes commented Nov 23, 2023

Thanks for helping out with this @can-anyscale

ujjawal-khare pushed a commit to ujjawal-khare-27/ray that referenced this pull request Nov 29, 2023
@can-anyscale @shrekris-anyscale @ujjawal-khare
Make Ray releases tests use pydantic>=2.5.0 (ray-project#41244)
e0af60c 
As a follow-up to ray-project#40451, this change makes all the Ray release tests use pydantic>=2.5.0.

Additional changes:

The linter now uses mypy==1.7.0.
All Ray release tests, including workspace templates, now use deepspeed>=0.12.3.
This change fix the serve_resnet_benchmark.py release test, which is broken on master.

---------

Signed-off-by: can <can@anyscale.com>
Signed-off-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Co-authored-by: Shreyas Krishnaswamy <shrekris@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrekris-anyscale shrekris-anyscale shrekris-anyscale left review comments

@ericl ericl ericl approved these changes

@matthewdeng matthewdeng matthewdeng approved these changes

@c21 c21 c21 approved these changes

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@aslonnie aslonnie aslonnie approved these changes

@richardliaw richardliaw Awaiting requested review from richardliaw

@krfricke krfricke Awaiting requested review from krfricke

@xwjiang2010 xwjiang2010 Awaiting requested review from xwjiang2010

@amogkam amogkam Awaiting requested review from amogkam

@Yard1 Yard1 Awaiting requested review from Yard1

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@justinvyu justinvyu Awaiting requested review from justinvyu

@woshiyyya woshiyyya Awaiting requested review from woshiyyya

@edoakes edoakes Awaiting requested review from edoakes

Assignees
No one assigned
Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@can-anyscale @shrekris-anyscale @edoakes @ericl @matthewdeng @c21 @kouroshHakha @aslonnie @architkulkarni