[core][dashboard] Change file_tail_iterator to async. #47721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
kevin85421
approved these changes
Sep 17, 2024
|
didn't take time to blame out the problematic pr... |
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
|
@kevin85421 so it's #44658 from 5 mo ago I think |
|
Hi @rynewang @kevin85421 will this fix be included in the ray nightly release? thanks! |
4 tasks
ujjawal-khare
pushed a commit
to ujjawal-khare-27/ray
that referenced
this pull request
Oct 15, 2024
) On `ray job submit`, the CLI tails logs from the job agent. The agent needs to read log tails from an iterator and yields to a WebSocket. However the file reading iterator is SYNC so it blocks agent event loop, causing the agent to block, making downstream consumers like KubeRay to break. Changes the log reading function `file_tail_iterator` to an AsyncIterator and a 1s `time.sleep` to `asyncio.sleep` to unblock. Signed-off-by: Ruiyang Wang <rywang014@gmail.com> Signed-off-by: ujjawal-khare <ujjawal.khare@dream11.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On
ray job submit, the CLI tails logs from the job agent. The agent needs to read log tails from an iterator and yields to a WebSocket. However the file reading iterator is SYNC so it blocks agent event loop, causing the agent to block, making downstream consumers like KubeRay to break. Changes the log reading functionfile_tail_iteratorto an AsyncIterator and a 1stime.sleeptoasyncio.sleepto unblock.The issue was introduced from #44658.
Fixes #47637.
Fixes ray-project/kuberay#2355