Skip to content

Use Go 1.24.0 in go module #3835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Use Go 1.24.0 in go module #3835

merged 2 commits into from
Jul 3, 2025

Conversation

tenzen-y
Copy link
Contributor

@tenzen-y tenzen-y commented Jun 26, 2025 •
edited
Loading

Why are these changes needed?

As I described in the related issue, this patch version will be delivered to child and grand child projets.
I would like to avoid such situations.

Related issue number

Closes #3834

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@tenzen-y
Use Go 1.24.0 in the go module
c4c01ce 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y mentioned this pull request Jun 26, 2025
Closed
mbobrovskyi
mbobrovskyi reviewed Jun 26, 2025
View reviewed changes
go.mod
Copy link
Contributor

@mbobrovskyi mbobrovskyi Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update other places:

kuberay/.pre-commit-config.yaml

Line 6 in c4c01ce

golang: 1.24.2

kuberay/ray-operator/Dockerfile

Line 2 in c4c01ce

FROM golang:1.24.2-bullseye AS builder

kuberay/apiserver/Dockerfile

Line 2 in c4c01ce

FROM golang:1.24.2-bullseye AS builder

kuberay/experimental/Dockerfile

Line 2 in c4c01ce

FROM golang:1.24.2-bullseye AS builder

kuberay/proto/Dockerfile

Line 2 in c4c01ce

FROM golang:1.24.2-bullseye AS generator

kuberay/ray-operator/DEVELOPMENT.md

Lines 27 to 29 in c4c01ce

go install golang.org/dl/go1.24.2@latest
go1.24.2 download
export GOROOT=$(go1.24.2 env GOROOT)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.
However, I think we might want to keep Go version in Dockerfile.
I can up the decision to KubeRay maintainers. @andrewsykim @kevin85421

Anyway, pre-commit-config and DEVELOPMENT.md should be updated.

Copy link
Contributor Author

@tenzen-y tenzen-y Jun 26, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I revisit for pre-commit-config and DEVELOPMENT.md, those can also still point to the 1.24.2 since 1.24.0 in go.mod indicates greater than 1.24.0 should be compatible.

Anyway, I want to hear the KubeRay maintainer's opinion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @kevin85421 @andrewsykim

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response—I just finished the release process this week. It's better to keep the Go version consistent across the entire repo. How about updating the Dockerfile's Go version to 1.24.0 as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking that!
Sure, we can replace all with 1.24.0.

@tenzen-y
Copy link
Contributor Author

tenzen-y commented Jul 3, 2025

@kevin85421 I replaced all Go versions with v1.24.0.
PTAL, thanks.

@kevin85421
Copy link
Member

@tenzen-y thanks! Please ping me when all CI tests pass. Thank you!

@tenzen-y
Use Go 1.24.0 across an entire repository
c650c96 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@tenzen-y
Copy link
Contributor Author

tenzen-y commented Jul 3, 2025

I accidentally replaced the ENVTEST_K8S_VERSION even though that is not Go version.
So, I reverted the change.

@tenzen-y
Copy link
Contributor Author

tenzen-y commented Jul 3, 2025

@kevin85421 Sorry for the bother. Could you approve actions CI?

@kevin85421
Copy link
Member

@kevin85421 Sorry for the bother. Could you approve actions CI?

Approved

@tenzen-y
Copy link
Contributor Author

tenzen-y commented Jul 3, 2025

@kevin85421 Sorry for the bother. Could you approve actions CI?

Approved

@kevin85421 Thank you.
All CIs are succeeded.

@tenzen-y
Copy link
Contributor Author

tenzen-y commented Jul 3, 2025 •
edited
Loading

Additionally, I hope to deliver this change to the next kuberay patch version so that we can avoid Go patch version delivering. Could we cherry-pick to the release branch?

@kevin85421
Copy link
Member

Additionally, I hope to deliver this change to the next kuberay patch version so that we can avoid Go patch version delivering. Could we cherry-pick to the release branch?

Sure, do you have a timeline in mind?

@kevin85421 kevin85421 merged commit 9be8abd into ray-project:master Jul 3, 2025
25 checks passed
@tenzen-y
Copy link
Contributor Author

tenzen-y commented Jul 4, 2025

Additionally, I hope to deliver this change to the next kuberay patch version so that we can avoid Go patch version delivering. Could we cherry-pick to the release branch?

Sure, do you have a timeline in mind?

@kevin85421 I do not have a specific timeline, but this is a blocker for kubernetes-sigs/kueue#5722.

@mimowo, Do you have any timeline for upgrading the KubeRay version in the Kueue repository?

tenzen-y added a commit to tenzen-y/kuberay that referenced this pull request Jul 4, 2025
@tenzen-y
Use Go 1.24.0 in go module (ray-project#3835)
df37b2f
@tenzen-y tenzen-y mentioned this pull request Jul 4, 2025
Merged
4 tasks
@tenzen-y tenzen-y deleted the use-go-1240 branch July 4, 2025 04:41
@mimowo
Copy link

mimowo commented Jul 4, 2025

Thank you @tenzen-y for driving it.

@mimowo, Do you have any timeline for upgrading the KubeRay version in the Kueue repository?

I would like to upgrade it before the next minor release of Kueue which is planned for mid July.

kevin85421 pushed a commit that referenced this pull request Jul 4, 2025
@tenzen-y
Cherry-pick: Use Go 1.24.0 in go module (#3835) (#3846)
0e6b464
@kevin85421 kevin85421 mentioned this pull request Jul 5, 2025
Closed
2 tasks
DW-Han pushed a commit to DW-Han/kuberay that referenced this pull request Jul 30, 2025
@tenzen-y @DW-Han
Use Go 1.24.0 in go module (ray-project#3835)
657d0ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

+1 more reviewer

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid requiring specific Go patch version in go module
4 participants
@tenzen-y @kevin85421 @mimowo @mbobrovskyi