Skip to content

[Metrics] Remove serviceMonitor.yaml #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 18, 2025
Merged

[Metrics] Remove serviceMonitor.yaml #3795

merged 1 commit into from
Jun 18, 2025

Conversation

owenowenisme
Copy link
Contributor

Why are these changes needed?

Now we install serviceMonitor for kuberay operator only with helm chart, so this file is deleted.

Related issue number

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@owenowenisme
remove servicemonitor yaml
f91042d 
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
@owenowenisme owenowenisme marked this pull request as ready for review June 18, 2025 02:13
@owenowenisme
Copy link
Contributor Author

@troychiu @win5923 @troychiu PTAL

@kevin85421 kevin85421 merged commit d40692f into ray-project:master Jun 18, 2025
25 checks passed
@owenowenisme owenowenisme deleted the metrics/remove-servicemonitor-yaml branch June 18, 2025 07:41
MortalHappiness pushed a commit to MortalHappiness/kuberay that referenced this pull request Jun 18, 2025
@owenowenisme @MortalHappiness
[Metrics] Remove serviceMonitor.yaml (ray-project#3795)
469b106 
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
MortalHappiness added a commit that referenced this pull request Jun 18, 2025
@MortalHappiness @owenowenisme
[Metrics] Remove serviceMonitor.yaml (#3795) (#3798)
b5cdd00 
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Co-authored-by: Owen Lin (You-Cheng Lin) <106612301+owenowenisme@users.noreply.github.com>
chipspeak pushed a commit to chipspeak/kuberay that referenced this pull request Jul 2, 2025
@owenowenisme @chipspeak
[Metrics] Remove serviceMonitor.yaml (ray-project#3795)
fbb4897 
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
kryanbeane pushed a commit to kryanbeane/kuberay that referenced this pull request Jul 2, 2025
@owenowenisme @kryanbeane
[Metrics] Remove serviceMonitor.yaml (ray-project#3795)
1326ee0 
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
DW-Han pushed a commit to DW-Han/kuberay that referenced this pull request Jul 30, 2025
@owenowenisme @DW-Han
[Metrics] Remove serviceMonitor.yaml (ray-project#3795)
f43be33 
Signed-off-by: You-Cheng Lin <mses010108@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin85421 kevin85421 kevin85421 approved these changes

+1 more reviewer

@troychiu troychiu troychiu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owenowenisme @kevin85421 @troychiu